From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753609Ab3BRJ1K (ORCPT ); Mon, 18 Feb 2013 04:27:10 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:2500 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751885Ab3BRJ1H convert rfc822-to-8bit (ORCPT ); Mon, 18 Feb 2013 04:27:07 -0500 X-IronPort-AV: E=Sophos;i="4.84,686,1355068800"; d="scan'208";a="6723768" Subject: Re: [PATCH] Input: psmouse - retry getid command in psmouse_probe() From: li guang To: Chung-yih Wang Cc: linux-input@vger.kernel.org, Dmitry Torokhov , Tai-hwa Liang , Rusty Russell , Paul Fox , linux-kernel@vger.kernel.org In-Reply-To: <1351678279-32615-1-git-send-email-cywang@chromium.org> References: <1351678279-32615-1-git-send-email-cywang@chromium.org> Date: Mon, 18 Feb 2013 17:26:00 +0800 Message-ID: <1361179560.7859.5.camel@liguang.fnst.cn.fujitsu.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/18 17:25:22, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/18 17:25:23, Serialize complete at 2013/02/18 17:25:23 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org seems a special change for a special device so, you may need to place this change with corresponding CONFIG_xxx_xxx. generally, if command F2 failed, we will assume there's no ps2 device, it's normal, or do you have some materials(SPEC) to specify the change you have made? 在 2012-10-31三的 18:11 +0800，Chung-yih Wang写道： > As the synaptics device may not respond to the first command in psmouse_probe > when a machine is booting up, the patch gives a second probe if the first > one fails. > > Signed-off-by: Chung-yih Wang > --- > drivers/input/mouse/psmouse-base.c | 13 +++++++++++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c > index 22fe254..c4fc5ad 100644 > --- a/drivers/input/mouse/psmouse-base.c > +++ b/drivers/input/mouse/psmouse-base.c > @@ -1053,8 +1053,17 @@ static int psmouse_probe(struct psmouse *psmouse) > */ > > param[0] = 0xa5; > - if (ps2_command(ps2dev, param, PSMOUSE_CMD_GETID)) > - return -1; > + if (ps2_command(ps2dev, param, PSMOUSE_CMD_GETID)) { > + /* > + * Reprobe the device if it did not respond to the GETID > + * command. Before retry, additional dummy command is sent > + * to clear the 'RESEND' response if exists. > + */ > + psmouse_warn(psmouse, "GETID probe failed, retrying...\n"); > + ps2_command(ps2dev, NULL, PSMOUSE_CMD_SETSCALE11); > + if (ps2_command(ps2dev, param, PSMOUSE_CMD_GETID)) > + return -1; > + } > > if (param[0] != 0x00 && param[0] != 0x03 && > param[0] != 0x04 && param[0] != 0xff)