From: Mike Galbraith <efault@gmx.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Turner <pjt@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Clark Williams <clark@redhat.com>,
Andrew Theurer <habanero@us.ibm.com>
Subject: Re: [RFC] sched: The removal of idle_balance()
Date: Mon, 18 Feb 2013 18:22:16 +0100 [thread overview]
Message-ID: <1361208136.14352.226.camel@marge.simpson.net> (raw)
In-Reply-To: <1361200989.23152.150.camel@gandalf.local.home>
On Mon, 2013-02-18 at 10:23 -0500, Steven Rostedt wrote:
> On Mon, 2013-02-18 at 04:42 +0100, Mike Galbraith wrote:
> > On Sun, 2013-02-17 at 16:54 -0500, Steven Rostedt wrote:
> > > On Sun, 2013-02-17 at 08:14 +0100, Mike Galbraith wrote:
> > >
> > > > (And puts a dent in x264 ultrafast)
> >
> > > What about my last patch? The one that avoids idle_balance() if the
> > > previous task was in a task_uninterruptible state. That one gave the
> > > same performance increase that removing idle_balance() did on my box.
> >
> > I didn't try it, figuring it was pretty much the same as turning it off,
> > but just did. Patch (-typo) has no effect on either x264 or hackbench
> > (surely will for -rt, but rt tasks here aren't sent to burn in rt hell).
>
> So it had no effect to your tests? That's actually good, as if it has a
> positive effect on some workloads and no effect on others, that's still
> a net win.
Yeah, for clarity, with "!" removed, there was zero effect to either
hackbench or x264 ultrafast.
-Mike
next prev parent reply other threads:[~2013-02-18 17:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 6:13 Steven Rostedt
2013-02-15 7:26 ` Mike Galbraith
2013-02-15 12:07 ` Peter Zijlstra
2013-02-15 12:21 ` Peter Zijlstra
2013-02-15 12:32 ` Mike Galbraith
2013-02-16 16:12 ` Steven Rostedt
2013-02-17 6:26 ` Mike Galbraith
2013-02-17 7:14 ` Mike Galbraith
2013-02-17 21:54 ` Steven Rostedt
2013-02-18 3:42 ` Mike Galbraith
2013-02-18 15:23 ` Steven Rostedt
2013-02-18 17:22 ` Mike Galbraith [this message]
2013-02-15 7:45 ` Joonsoo Kim
2013-02-15 15:05 ` Steven Rostedt
2013-02-17 6:26 ` Mike Galbraith
2013-02-18 8:13 ` Srikar Dronamraju
2013-02-18 15:25 ` Steven Rostedt
2013-02-19 4:13 ` Rakib Mullick
2013-02-19 7:29 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361208136.14352.226.camel@marge.simpson.net \
--to=efault@gmx.de \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=clark@redhat.com \
--cc=fweisbec@gmail.com \
--cc=habanero@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome