From: Steven Rostedt <rostedt@goodmis.org>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: jaegeuk.kim@samsung.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Namjae Jeon <namjae.jeon@samsung.com>,
Pankaj Kumar <pankaj.km@samsung.com>
Subject: Re: [PATCH 2/8] f2fs: add tracepoints for inode operations
Date: Mon, 18 Feb 2013 21:52:06 -0500 [thread overview]
Message-ID: <1361242326.23152.189.camel@gandalf.local.home> (raw)
In-Reply-To: <1361241190-18073-1-git-send-email-linkinjeon@gmail.com>
On Tue, 2013-02-19 at 11:33 +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> +TRACE_EVENT(f2fs_unlink_exit,
> + TP_PROTO(struct dentry *dentry, int ret),
> +
> + TP_ARGS(dentry, ret),
> +
> + TP_STRUCT__entry(
> + __field(ino_t, ino)
> + __field(dev_t, dev)
> + __field(int, ret)
> + ),
> +
> + TP_fast_assign(
> + __entry->ino = dentry->d_inode->i_ino;
> + __entry->dev = dentry->d_inode->i_sb->s_dev;
> + __entry->ret = ret;
> + ),
> +
> + TP_printk("dev %d,%d ino %lu ret %d",
> + MAJOR(__entry->dev), MINOR(__entry->dev),
> + (unsigned long) __entry->ino,
> + __entry->ret)
> +);
> +
> #endif /* _TRACE_F2FS_H */
>
> /* This part must be outside protection */
If at all possible, try to combine as many tracepoints as possible by a
class. A TRACE_EVENT() is really a DECLARE_EVENT_CLASS();
DEFINE_EVENT(); pair that totals about 5k per TRACE_EVENT(). The
DECLARE_EVENT_CLASS() being the majority of that. A DEFINE_EVENT() adds
approximately 250 bytes each. Thus, combining the above with the
TRACE_EVENT() from the previous patch:
+TRACE_EVENT(f2fs_sync_file_exit,
+ TP_PROTO(struct inode *inode, int ret),
+
+ TP_ARGS(inode, ret),
+
+ TP_STRUCT__entry(
+ __field(int, ret)
+ __field(ino_t, ino)
+ __field(dev_t, dev)
+ ),
+
+ TP_fast_assign(
+ __entry->ret = ret;
+ __entry->ino = inode->i_ino;
+ __entry->dev = inode->i_sb->s_dev;
+ ),
+
+ TP_printk("dev %d,%d ino %lu ret %d",
+ MAJOR(__entry->dev), MINOR(__entry->dev),
+ (unsigned long) __entry->ino,
+ __entry->ret)
+);
into:
DECLARE_EVENT_CLASS(f2fs_dev_inode_ret,
TP_PROTO(struct inode *inode, int ret),
TP_ARGS(inode, ret),
TP_STRUCT__entry(
__field(int, ret)
__field(ino_t, ino)
__field(dev_t, dev)
),
TP_fast_assign(
__entry->ret = ret;
__entry->ino = inode->i_ino;
__entry->dev = inode->i_sb->s_dev;
),
TP_printk("dev %d,%d ino %lu ret %d",
MAJOR(__entry->dev), MINOR(__entry->dev),
(unsigned long) __entry->ino,
__entry->ret)
);
DEFINE_EVENT(f2fs_sync_file_exit,
TP_PROTO(struct inode *inode, int ret),
TP_ARGS(inode, ret));
DEFINE_EVENT(f2fs_unlink_exit,
TP_PROTO(struct inode *inode, int ret),
TP_ARGS(inode, ret));
You can save ~4750 bytes. Note, you will need to pass the inode instead
of the dentry into f2fs_unlink_exit(), but you don't use the dentry
anyway.
-- Steve
next prev parent reply other threads:[~2013-02-19 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 2:33 Namjae Jeon
2013-02-19 2:52 ` Steven Rostedt [this message]
2013-02-20 5:58 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361242326.23152.189.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jaegeuk.kim@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pankaj.km@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®