mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Holler <holler@ahsoftware.de>,
	Jiri Kosina <jkosina@suse.cz>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	linux-input@vger.kernel.org, srinivas.pandruvada@intel.com,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] HID: make sensor autodetection independent of underlying bus
Date: Tue, 19 Feb 2013 11:22:33 +0200	[thread overview]
Message-ID: <1361265753-17541-1-git-send-email-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <51221AFD.1090108@ahsoftware.de>

Instead of limiting HID sensors to USB and I2C busses we can just make
everything that has usage page of HID_UP_SENSOR to be included in
HID_GROUP_SENSOR_HUB group. This allows the sensor-hub to work over
bluetooth (and other transports) as well.

Reported-by: Alexander Holler <holler@ahsoftware.de>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/hid/hid-core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index fe3a59e..f89e902 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -728,8 +728,7 @@ static int hid_scan_report(struct hid_device *hid)
 		} else if (page == HID_UP_SENSOR &&
 			item.type == HID_ITEM_TYPE_MAIN &&
 			item.tag == HID_MAIN_ITEM_TAG_BEGIN_COLLECTION &&
-			(item_udata(&item) & 0xff) == HID_COLLECTION_PHYSICAL &&
-			(hid->bus == BUS_USB || hid->bus == BUS_I2C))
+			(item_udata(&item) & 0xff) == HID_COLLECTION_PHYSICAL)
 			hid->group = HID_GROUP_SENSOR_HUB;
 	}
 
-- 
1.7.10.4


  reply	other threads:[~2013-02-19  9:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 10:31 [PATCH 1/3] HID: extend autodetect to handle I2C sensors as well Mika Westerberg
2013-02-11 10:31 ` [PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table Mika Westerberg
2013-02-11 11:21   ` Benjamin Tissoires
2013-02-11 15:53   ` Pandruvada, Srinivas
2013-02-11 17:12     ` Benjamin Tissoires
2013-02-18  9:26     ` Jiri Kosina
2013-02-11 10:31 ` [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus Mika Westerberg
2013-02-11 11:22   ` Benjamin Tissoires
2013-02-18  9:28     ` Jiri Kosina
2013-02-11 15:54   ` Pandruvada, Srinivas
2013-02-12  9:12     ` Mika Westerberg
2013-02-18 11:03   ` Alexander Holler
2013-02-18 11:12     ` Mika Westerberg
2013-02-18 11:22       ` Alexander Holler
2013-02-18 11:33         ` Mika Westerberg
2013-02-18 11:37           ` Alexander Holler
2013-02-18 11:54             ` Mika Westerberg
2013-02-18 12:13               ` Alexander Holler
2013-02-19  9:22                 ` Mika Westerberg [this message]
2013-02-21 10:42                   ` [PATCH] HID: make sensor autodetection independent of underlying bus Benjamin Tissoires
2013-02-25 12:43                     ` Jiri Kosina
2013-02-21 10:34                 ` [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus Benjamin Tissoires
2013-02-21 10:52                   ` Alexander Holler
2013-02-11 11:20 ` [PATCH 1/3] HID: extend autodetect to handle I2C sensors as well Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361265753-17541-1-git-send-email-mika.westerberg@linux.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=holler@ahsoftware.de \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome