From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935599Ab3BTDQb (ORCPT ); Tue, 19 Feb 2013 22:16:31 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:31573 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S934185Ab3BTDQ2 convert rfc822-to-8bit (ORCPT ); Tue, 19 Feb 2013 22:16:28 -0500 X-IronPort-AV: E=Sophos;i="4.84,699,1355068800"; d="scan'208";a="6732536" Subject: Re: [PATCH v4 1/4] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c From: li guang To: David Rientjes Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, x86@kernel.org, isimatu.yasuaki@jp.fujitsu.com In-Reply-To: References: <1360894992-14818-1-git-send-email-lig.fnst@cn.fujitsu.com> <1360894992-14818-2-git-send-email-lig.fnst@cn.fujitsu.com> <1361324355.7859.35.camel@liguang.fnst.cn.fujitsu.com> <1361325113.7859.37.camel@liguang.fnst.cn.fujitsu.com> <1361326913.7859.41.camel@liguang.fnst.cn.fujitsu.com> <1361327201.7859.44.camel@liguang.fnst.cn.fujitsu.com> Date: Wed, 20 Feb 2013 11:16:36 +0800 Message-ID: <1361330196.7859.51.camel@liguang.fnst.cn.fujitsu.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/20 11:15:46, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/02/20 11:15:47, Serialize complete at 2013/02/20 11:15:47 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2013-02-19二的 19:04 -0800,David Rientjes写道: > On Wed, 20 Feb 2013, li guang wrote: > > > > > No, it doesn't. From next-20130219, you're missing at least two patches: > > > > > > > > 3795e4893203 ("acpi, memory-hotplug: extend movablemem_map ranges to the end of node") > > > > 9a561f4dfd70 ("acpi, memory-hotplug: support getting hotplug info from SRAT") > > > > > > > > I'm trying to be patient in reviewing your patches, but please double > > > > check your work. > > > > > > I have to say my latest pull has these commit, and can apply > > > successfully. > > > really don't know why you can't apply. > > You should not be pulling linux-next, you should be fetching. > > > > I mean although my patches did not based on latest linux-next(miss > > several commits), but as I can see, they can be applied to latest > > linux-next (tag next-20130218) successfully. > > > > next-20130218 is not the latest linux-next as I've already said. Do this: > go to > http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=blob_plain;f=arch/x86/mm/srat.c;hb=HEAD > and search for handle_movablemem(). That's one of the functions added in > one of the commits I mentioned and was from February. Now search your > patch for handle_movablemem(). See a problem? Yes, I know there's no new changes in my patch as I said before(not based on lasted), but as I try to apply my patch(1/4), it will do the right work to move current srat.c from arch/x86/mm/ to arch/x86/kernel/acpi/ regardless of what I based is not latest.