From: Joe Perches <joe@perches.com>
To: Shuah Khan <shuahkhan@gmail.com>
Cc: Peter Hurley <peter@hurleysoftware.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Improve CamelCase test for Page
Date: Fri, 22 Feb 2013 15:06:28 -0800 [thread overview]
Message-ID: <1361574388.6168.6.camel@joe-AO722> (raw)
In-Reply-To: <CAKocOONj+gEcBXZJXGqoY00mcUf5WpLo7j7JF-S20UZED+pLCA@mail.gmail.com>
dOn Fri, 2013-02-22 at 15:57 -0700, Shuah Khan wrote:
> What are the guidelines on camelcase warnings on patches. A recent one
> I ran into is on a variable in a structure and fixing it would require
> changing the original variable.
The same as all other checkpatch warnings.
Ignore the ones you don't agree with.
Errors maybe should be fixed. You should be able
to ignore those too though.
> One would have to change a large portion of the code to fix it. In
> such cases, do we ignore this warning?
Yes.
Taste is always author's choice.
Of course, lots of things depends on the upstream
path and files you chose to work on.
If you're working in drivers/net, most of these
warnings seem more likely to get patches that have
them rejected.
If you're working on drivers/scsi, it seems you
don't have to bother running checkpatch at all.
next prev parent reply other threads:[~2013-02-22 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130222204253.A37B931C1C1@corp2gmr1-1.hot.corp.google.com>
2013-02-22 20:59 ` Joe Perches
2013-02-22 22:01 ` Peter Hurley
2013-02-22 22:05 ` Andrew Morton
2013-02-22 22:21 ` Peter Hurley
2013-02-22 22:21 ` Joe Perches
2013-02-22 22:38 ` Peter Hurley
2013-02-22 22:57 ` Shuah Khan
2013-02-22 23:06 ` Joe Perches [this message]
2013-02-22 23:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361574388.6168.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®