From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 6/8] HID: multitouch: remove explicit usbhid dependency
Date: Mon, 25 Feb 2013 11:31:48 +0100 [thread overview]
Message-ID: <1361788310-6048-7-git-send-email-benjamin.tissoires@gmail.com> (raw)
In-Reply-To: <1361788310-6048-1-git-send-email-benjamin.tissoires@gmail.com>
This patch is part of the cleanup of the HID drivers
against their low-level transport layer.
With new touchscreens relying on I2C, it's better to
handle now these dependencies before users get kernel oopses.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/hid/hid-multitouch.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 32258ba..184ac0a 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -32,7 +32,6 @@
#include <linux/slab.h>
#include <linux/usb.h>
#include <linux/input/mt.h>
-#include "usbhid/usbhid.h"
MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
@@ -907,7 +906,7 @@ static int mt_resume(struct hid_device *hdev)
intf = to_usb_interface(hdev->dev.parent);
interface = intf->cur_altsetting;
- dev = hid_to_usb_dev(hdev);
+ dev = interface_to_usbdev(intf);
/* Some Elan legacy devices require SET_IDLE to be set on resume.
* It should be safe to send it to other devices too.
--
1.8.1.2
next prev parent reply other threads:[~2013-02-25 10:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 10:31 [PATCH v2 0/8] hid driver transport cleanup Benjamin Tissoires
2013-02-25 10:31 ` [PATCH v2 1/8] HID: Extend the interface with report requests Benjamin Tissoires
2013-02-25 10:31 ` [PATCH v2 2/8] HID: Extend the interface with wait io request Benjamin Tissoires
2013-02-25 10:31 ` [PATCH v2 3/8] HID: Kconfig: Remove explicit transport layer dependencies Benjamin Tissoires
2013-02-25 10:31 ` [PATCH v2 4/8] HID: use hid_hw_request() instead of direct call to usbhid Benjamin Tissoires
2013-02-25 10:31 ` [PATCH v2 5/8] HID: use hid_hw_wait() " Benjamin Tissoires
2013-02-25 10:31 ` Benjamin Tissoires [this message]
2013-02-25 10:31 ` [PATCH v2 7/8] HID: multitouch: Copyright and note on regression tests Benjamin Tissoires
2013-02-25 10:31 ` [PATCH v2 8/8] HID: i2c-hid: implement request() callback Benjamin Tissoires
2013-02-25 12:29 ` [PATCH v2 0/8] hid driver transport cleanup Jiri Kosina
2013-02-25 13:41 ` David Herrmann
2013-02-25 15:06 ` Benjamin Tissoires
2013-02-28 11:30 ` David Herrmann
2013-02-25 14:16 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361788310-6048-7-git-send-email-benjamin.tissoires@gmail.com \
--to=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®