From: Michael Ellerman <michael@ellerman.id.au>
To: acme@infradead.org
Cc: <linux-kernel@vger.kernel.org>,
feng.tang@intel.com, namhyung.kim@lge.com, namhyung@kernel.org
Subject: [PATCH 1/2] perf annotate: Fix build with NO_NEWT=1
Date: Tue, 26 Feb 2013 16:02:02 +1100 [thread overview]
Message-ID: <1361854923-1814-1-git-send-email-michael@ellerman.id.au> (raw)
Commit 18c9e5c "Make it to be able to skip unannotatable symbols" broke
the build with NO_NEWT=1:
CC builtin-annotate.o
builtin-annotate.c: In function 'hists__find_annotations':
builtin-annotate.c:161:4: error: duplicate case value
builtin-annotate.c:154:4: error: previously used here
make: *** [builtin-annotate.o] Error 1
This is because without NEWT support K_LEFT is #defined to -1 in
utils/hist.h
Fix it by shifting the K_LEFT/K_RIGHT #defines out of the likely range
of error values.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
tools/perf/util/hist.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index 3862468..609a115 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -208,8 +208,8 @@ static inline int script_browse(const char *script_opt __maybe_unused)
return 0;
}
-#define K_LEFT -1
-#define K_RIGHT -2
+#define K_LEFT -1000
+#define K_RIGHT -2000
#endif
#ifdef GTK2_SUPPORT
--
1.7.10.4
next reply other threads:[~2013-02-26 5:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 5:02 Michael Ellerman [this message]
2013-02-26 5:02 ` [PATCH 2/2] perf report: " Michael Ellerman
2013-02-26 8:48 ` Feng Tang
2013-02-26 11:46 ` Michael Ellerman
2013-03-18 10:51 ` [tip:perf/urgent] " tip-bot for Michael Ellerman
2013-02-26 9:02 ` [PATCH 1/2] perf annotate: " Namhyung Kim
2013-02-27 1:14 ` li guang
2013-02-27 1:22 ` Michael Ellerman
2013-02-27 1:29 ` li guang
2013-02-27 1:29 ` li guang
2013-02-27 2:31 ` Namhyung Kim
2013-03-18 10:50 ` [tip:perf/urgent] " tip-bot for Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361854923-1814-1-git-send-email-michael@ellerman.id.au \
--to=michael@ellerman.id.au \
--cc=acme@infradead.org \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®