From: Joe Perches <joe@perches.com>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Simon Horman <horms@verge.net.au>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] kexec: Use min_t to simplify logic
Date: Tue, 26 Feb 2013 00:38:01 -0800 [thread overview]
Message-ID: <1361867881.2023.16.camel@joe-AO722> (raw)
In-Reply-To: <512C4881.90409@cn.fujitsu.com>
On Tue, 2013-02-26 at 13:30 +0800, Zhang Yanfei wrote:
> This is just a tweak: using min_t to simplify logic of variable
> assignments.
>
> v3:
> - cast type of (PAGE_SIZE - (maddr & ~PAGE_MASK)) into size_t.
Why? Isn't this just a redundant cast?
> diff --git a/kernel/kexec.c b/kernel/kexec.c
[]
> @@ -822,13 +822,9 @@ static int kimage_load_normal_segment(struct kimage *image,
[]
> + mchunk = min_t(size_t, mbytes,
> + (size_t)(PAGE_SIZE - (maddr & ~PAGE_MASK)));
#define min_t(type, x, y) ({ \
type __min1 = (x); \
type __min2 = (y); \
__min1 < __min2 ? __min1: __min2; })
next prev parent reply other threads:[~2013-02-26 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 5:15 [PATCH v3 1/2] kexec: fix wrong types of some local variables Zhang Yanfei
2013-02-26 5:30 ` [PATCH v3 2/2] kexec: Use min_t to simplify logic Zhang Yanfei
2013-02-26 8:38 ` Joe Perches [this message]
2013-02-26 8:49 ` Zhang Yanfei
2013-02-26 8:53 ` Andrew Morton
2013-02-26 8:55 ` Zhang Yanfei
2013-02-27 22:31 ` Andrew Morton
2013-03-01 1:31 ` [PATCH v3 1/2] kexec: fix wrong types of some local variables Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361867881.2023.16.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®