From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759320Ab3BZXf1 (ORCPT ); Tue, 26 Feb 2013 18:35:27 -0500 Received: from webmail.solarflare.com ([12.187.104.25]:10410 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226Ab3BZXfZ (ORCPT ); Tue, 26 Feb 2013 18:35:25 -0500 Message-ID: <1361921710.2996.19.camel@bwh-desktop.uk.solarflarecom.com> Subject: Re: [E1000-devel] [PATCH RESEND 3/3] e1000e: fix accessing to suspended device From: Ben Hutchings To: Konstantin Khlebnikov CC: "Waskiewicz Jr, Peter P" , , , , "Rafael J. Wysocki" , Bruce Allan Date: Tue, 26 Feb 2013 23:35:10 +0000 In-Reply-To: <512C8889.80107@openvz.org> References: <20130225051010.12689.28611.stgit@zurg> <20130225051911.12689.11167.stgit@zurg> <512C0B59.4020209@intel.com> <512C8889.80107@openvz.org> Organization: Solarflare Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.17.20.137] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-19668.000 X-TM-AS-Result: No--22.945600-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-02-26 at 14:03 +0400, Konstantin Khlebnikov wrote: > Waskiewicz Jr, Peter P wrote: > > On 2/24/2013 9:19 PM, Konstantin Khlebnikov wrote: > >> This patch fixes some annoying messages like 'Error reading PHY register' and > >> 'Hardware Erorr' and saves several seconds on reboot. > > > > Any networking-related patches should also include netdev@vger.kernel.org. > > Yeah, I forgot about this, since I came here from PCI-bus side, not from the network =) > > > > > I'm also a bit confused how the changes below match the patch description. > > Elaborating a bit more how the changes suppress the messages might be a good thing. > > Patch eliminates reason of these errors -- now driver will wake up > the device before accessing to its registers. [...] But e1000e calls netif_device_detach() when entering run-time suspend. That currently prevents any ethtool operations from running until it resumes. (This is definitely a misfeature of either the ethtool core or e1000e. It is absolutely ridiculous that I can't check the PHY settings of an e1000e - or even driver information! - when the link is down.) Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.