mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jlec@gentoo.org
To: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Justin Lecher <jlec@gentoo.org>
Subject: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs
Date: Fri,  1 Mar 2013 16:50:44 +0100	[thread overview]
Message-ID: <1362153044-23611-3-git-send-email-jlec@gentoo.org> (raw)
In-Reply-To: <1362153044-23611-1-git-send-email-jlec@gentoo.org>

From: Justin Lecher <jlec@gentoo.org>

When building ncurses with --with-termlib several symbols get moved from
libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
additionally needs to link with libtinfo.so. Ncurses provides a config script
(ncurses5-config) or in very recent version even a pkg-config module to assist
finding ncurses.

This patch makes use of it to detect the necessary libs for linking of the
ncurses nconfig dialog

Signed-off-by: Justin Lecher <jlec@gentoo.org>
---
 scripts/kconfig/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 231b475..cc81db5 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -219,7 +219,11 @@ HOSTCFLAGS_gconf.o	= `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \
 
 HOSTLOADLIBES_mconf   = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC))
 
-HOSTLOADLIBES_nconf	= -lmenu -lpanel -lncurses
+HOSTLOADLIBES_nconf	= -lmenu -lpanel
+HOSTLOADLIBES_nconf	+= $(shell \
+				pkg-config --libs ncurses 2>/dev/null \
+				|| ncurses5-config --libs 2>/dev/null \
+				|| ncurses6-config --libs 2>/dev/null  )
 $(obj)/qconf.o: $(obj)/.tmp_qtcheck
 
 ifeq ($(qconf-target),1)
-- 
1.8.1.4


  parent reply	other threads:[~2013-03-01 15:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 15:50 ncurses detection for nconfig/menuconfig patches revised jlec
2013-03-01 15:50 ` [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs jlec
2013-03-03 20:36   ` Yann E. MORIN
2013-03-03 21:20     ` Justin
2013-03-01 15:50 ` jlec [this message]
2013-03-03 20:38   ` [PATCH 2/2] kconfig: " Yann E. MORIN
  -- strict thread matches above, loose matches on Subject: below --
2013-02-28  9:59 jlec
2013-02-28 20:59 ` Yann E. MORIN
2013-03-01  7:48   ` justin
2013-02-28 21:50 ` Sven Joachim
2013-03-01  7:37   ` justin
2013-03-01  8:36     ` Sven Joachim
2013-03-01 13:47       ` justin
2013-03-01 17:04         ` Sven Joachim
2013-03-03 20:23   ` Yann E. MORIN
2013-03-03 21:37     ` Sven Joachim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362153044-23611-3-git-send-email-jlec@gentoo.org \
    --to=jlec@gentoo.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®