From: Joe Perches <joe@perches.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: checkpatch bailing out
Date: Sat, 02 Mar 2013 05:07:54 -0800 [thread overview]
Message-ID: <1362229674.2254.5.camel@joe-AO722> (raw)
In-Reply-To: <5131EA60.40607@broadcom.com>
On Sat, 2013-03-02 at 13:02 +0100, Arend van Spriel wrote:
> With my laptop being broken I have to work on a server provided by my
> employer and I am preparing some patches for submission. So I intended
> to run checkpatch, but I get the following message after which the
> script bails out:
>
> $ git format-patch -1 --stdout | scripts/checkpatch.pl -
> Nested quantifiers in regex; marked by <-- HERE in m/(\((?:[^\(\)]++ <--
> HERE |(?-1))*\))/ at scripts/checkpatch.pl line 347.
>
> The server runs RHEL5
>
> 2.6.18-308.20.1.el5 #1 SMP x86_64 GNU/Linux
>
> Perl interpreter:
>
> $ /usr/bin/perl -v
>
> This is perl, v5.8.8 built for x86_64-linux-thread-multi
>
> My repository is based on wireless-testing repo.
>
> Did a quick search on LKML, but not finding anything like this. Any help
> would be appreciated here.
Sorry, I don't have perl 5.8.8, it's pretty old.
Perhaps this explains it:
http://www.perlmonks.org/?node_id=971814 (question)
http://www.perlmonks.org/?node_id=971883 (explanation)
Perhaps you could test this patch?
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b28cc38..fb53845 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -344,7 +344,7 @@ our $Typecast = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
# requires at least perl version v5.10.0
# Any use must be runtime checked with $^V
-our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
+our $balanced_parens = qr/(\((?:(?>[^\(\)]+)|(?-1))*\))/;
our $LvalOrFunc = qr{($Lval)\s*($balanced_parens{0,1})\s*};
our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
next prev parent reply other threads:[~2013-03-02 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 12:02 Arend van Spriel
2013-03-02 13:07 ` Joe Perches [this message]
2013-03-02 13:26 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362229674.2254.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=arend@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®