mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	devel@driverdev.osuosl.org
Cc: dan.magenheimer@oracle.com,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 04/11] zcache: The last of the atomic reads has now an accessory function.
Date: Mon,  4 Mar 2013 13:18:14 -0500	[thread overview]
Message-ID: <1362421101-15896-5-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1362421101-15896-1-git-send-email-konrad.wilk@oracle.com>

And now we can move the code ([inc|dec]_zcache_[*]) to their own file
with a header to make them nops or feed in debugfs.

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/staging/zcache/zcache-main.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index 4272ab9..f455151 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -253,6 +253,14 @@ static inline void dec_zcache_pers_zpages(unsigned zpages)
 {
 	zcache_pers_zpages = atomic_sub_return(zpages, &zcache_pers_zpages_atomic);
 }
+
+static inline unsigned long curr_pageframes_count(void)
+{
+	return zcache_pageframes_alloced -
+		atomic_read(&zcache_pageframes_freed_atomic) -
+		atomic_read(&zcache_eph_pageframes_atomic) -
+		atomic_read(&zcache_pers_pageframes_atomic);
+};
 /* but for the rest of these, counting races are ok */
 static ssize_t zcache_flush_total;
 static ssize_t zcache_flush_found;
@@ -565,10 +573,7 @@ static void zcache_free_page(struct page *page)
 		BUG();
 	__free_page(page);
 	inc_zcache_pageframes_freed();
-	curr_pageframes = zcache_pageframes_alloced -
-			atomic_read(&zcache_pageframes_freed_atomic) -
-			atomic_read(&zcache_eph_pageframes_atomic) -
-			atomic_read(&zcache_pers_pageframes_atomic);
+	curr_pageframes = curr_pageframes_count();
 	if (curr_pageframes > max_pageframes)
 		max_pageframes = curr_pageframes;
 	if (curr_pageframes < min_pageframes)
-- 
1.8.0.2


  parent reply	other threads:[~2013-03-04 18:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 18:18 [PATCH] Various fixes for zcache for v3.10 Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 01/11] zcache: s/int/bool/ on the various options Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 02/11] zcache: Provide accessory functions for counter increase Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 03/11] zcache: Provide accessory functions for counter decrease Konrad Rzeszutek Wilk
2013-03-04 18:18 ` Konrad Rzeszutek Wilk [this message]
2013-03-04 18:18 ` [PATCH 05/11] zcache: Make the debug code use pr_debug Konrad Rzeszutek Wilk
2013-03-04 18:28   ` Joe Perches
2013-03-05 21:54     ` Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 06/11] zcache: Move debugfs code out of zcache-main.c file Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 07/11] zcache/debug: Use an array to initialize/use debugfs attributes Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 08/11] zcache: Move the last of the debugfs counters out Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 09/11] zcache: Module license is defined twice Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 10/11] zcache/debug: Coalesce all debug under CONFIG_ZCACHE_DEBUG Konrad Rzeszutek Wilk
2013-03-04 18:18 ` [PATCH 11/11] zcache/zbud: Add incremental accessory counters Konrad Rzeszutek Wilk
2013-03-05  8:44   ` Greg KH
2013-03-05 14:02     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362421101-15896-5-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®