From: Borislav Petkov <bp@alien8.de>
To: X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>
Subject: [PATCH 4/5] x86, msr: Unify variable names
Date: Mon, 4 Mar 2013 21:16:19 +0100 [thread overview]
Message-ID: <1362428180-8865-5-git-send-email-bp@alien8.de> (raw)
In-Reply-To: <1362428180-8865-1-git-send-email-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
Make sure all MSR-accessing primitives which split MSR values in
two 32-bit parts have their variables called 'low' and 'high' for
consistence with the rest of the code and for ease of staring.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/include/asm/msr.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index 9264802e2824..cb7502852acb 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -137,11 +137,11 @@ static inline unsigned long long native_read_pmc(int counter)
* pointer indirection), this allows gcc to optimize better
*/
-#define rdmsr(msr, val1, val2) \
+#define rdmsr(msr, low, high) \
do { \
u64 __val = native_read_msr((msr)); \
- (void)((val1) = (u32)__val); \
- (void)((val2) = (u32)(__val >> 32)); \
+ (void)((low) = (u32)__val); \
+ (void)((high) = (u32)(__val >> 32)); \
} while (0)
static inline void wrmsr(unsigned msr, unsigned low, unsigned high)
@@ -162,12 +162,12 @@ static inline int wrmsr_safe(unsigned msr, unsigned low, unsigned high)
}
/* rdmsr with exception handling */
-#define rdmsr_safe(msr, p1, p2) \
+#define rdmsr_safe(msr, low, high) \
({ \
int __err; \
u64 __val = native_read_msr_safe((msr), &__err); \
- (*p1) = (u32)__val; \
- (*p2) = (u32)(__val >> 32); \
+ (*low) = (u32)__val; \
+ (*high) = (u32)(__val >> 32); \
__err; \
})
@@ -208,7 +208,7 @@ do { \
#define wrmsrl_safe(msr, val) wrmsr_safe((msr), (u32)(val), \
(u32)((val) >> 32))
-#define write_tsc(val1, val2) wrmsr(MSR_IA32_TSC, (val1), (val2))
+#define write_tsc(low, high) wrmsr(MSR_IA32_TSC, (low), (high))
#define write_rdtscp_aux(val) wrmsr(MSR_TSC_AUX, (val), 0)
--
1.8.1.3.535.ga923c31
next prev parent reply other threads:[~2013-03-04 20:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 20:16 [PATCH 0/5] x86: Misc fixlets Borislav Petkov
2013-03-04 20:16 ` [PATCH 1/5] x86, smpboot: Remove unused variable Borislav Petkov
2013-03-06 0:24 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2013-03-04 20:16 ` [PATCH 2/5] x86: Drop KERNEL_IMAGE_START Borislav Petkov
2013-04-03 0:18 ` [tip:x86/cleanups] " tip-bot for Borislav Petkov
2013-03-04 20:16 ` [PATCH 3/5] x86-64, docs, mm: Add vsyscall range to virtual address space layout Borislav Petkov
2013-03-04 21:45 ` Andy Lutomirski
2013-03-04 21:56 ` Borislav Petkov
2013-04-03 0:19 ` [tip:x86/cleanups] " tip-bot for Borislav Petkov
2013-03-04 20:16 ` Borislav Petkov [this message]
2013-04-03 0:20 ` [tip:x86/cleanups] x86, msr: Unify variable names tip-bot for Borislav Petkov
2013-03-04 20:16 ` [PATCH 5/5] x86, quirks: Shut-up a long-standing gcc warning Borislav Petkov
2013-04-03 0:21 ` [tip:x86/cleanups] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362428180-8865-5-git-send-email-bp@alien8.de \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome