mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: linux-usb@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>,
	linux-kernel@vger.kernel.org,
	Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets
Date: Mon,  4 Mar 2013 22:28:09 +0100	[thread overview]
Message-ID: <1362432489-6325-1-git-send-email-sebastian@breakpoint.cc> (raw)
In-Reply-To: <20130206020424.GB1175@localhost>

Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc
into the kernel. The problem was that u_serial was used by g_cdc before
u_serial was initialized. In the module case eveything is initialized in
the correct order but if we compile it into the kernel we rely on
Makefile order which I did wrong and now I correct this.

Cc: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
I kinda assumed that this was already fixed (i.e. a patch like this was sent)
but it seems not to be that case.

 drivers/usb/gadget/Makefile |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
index 97a13c3..1ded3d4 100644
--- a/drivers/usb/gadget/Makefile
+++ b/drivers/usb/gadget/Makefile
@@ -35,6 +35,12 @@ mv_udc-y			:= mv_udc_core.o
 obj-$(CONFIG_USB_FUSB300)	+= fusb300_udc.o
 obj-$(CONFIG_USB_MV_U3D)	+= mv_u3d_core.o
 
+# USB Functions
+obj-$(CONFIG_USB_U_SERIAL)	+= u_serial.o
+obj-$(CONFIG_USB_F_ACM)		+= f_acm.o
+f_ss_lb-y			:= f_loopback.o f_sourcesink.o
+obj-$(CONFIG_USB_F_SS_LB)	+= f_ss_lb.o
+
 #
 # USB gadget drivers
 #
@@ -74,9 +80,3 @@ obj-$(CONFIG_USB_G_WEBCAM)	+= g_webcam.o
 obj-$(CONFIG_USB_G_NCM)		+= g_ncm.o
 obj-$(CONFIG_USB_G_ACM_MS)	+= g_acm_ms.o
 obj-$(CONFIG_USB_GADGET_TARGET)	+= tcm_usb_gadget.o
-
-# USB Functions
-obj-$(CONFIG_USB_F_ACM)		+= f_acm.o
-f_ss_lb-y			:= f_loopback.o f_sourcesink.o
-obj-$(CONFIG_USB_F_SS_LB)	+= f_ss_lb.o
-obj-$(CONFIG_USB_U_SERIAL)	+= u_serial.o
-- 
1.7.10.4


  parent reply	other threads:[~2013-03-04 21:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06  2:04 [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common() Fengguang Wu
2013-02-27 10:49 ` Felipe Balbi
2013-03-02 13:37   ` Fengguang Wu
2013-03-02 13:41     ` Sebastian Andrzej Siewior
2013-03-02 13:45       ` Fengguang Wu
2013-03-04 21:28 ` Sebastian Andrzej Siewior [this message]
2013-03-04 22:40   ` [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets Michal Nazarewicz
2013-03-05  9:57   ` Fengguang Wu
2013-03-05 10:35     ` Fengguang Wu
2013-03-05 19:18       ` Sebastian Andrzej Siewior
2013-03-05 10:49   ` Felipe Balbi
2013-03-05 19:16     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362432489-6325-1-git-send-email-sebastian@breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=balbi@ti.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome