From: Mike Galbraith <efault@gmx.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Michael Wang <wangyun@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Alex Shi <alex.shi@intel.com>,
Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Nikunj A. Dadhania" <nikunj@linux.vnet.ibm.com>,
Ram Pai <linuxram@us.ibm.com>
Subject: Re: [PATCH] sched: wakeup buddy
Date: Thu, 07 Mar 2013 10:43:39 +0100 [thread overview]
Message-ID: <1362649419.4652.12.camel@marge.simpson.net> (raw)
In-Reply-To: <1362645372.2606.11.camel@laptop>
On Thu, 2013-03-07 at 09:36 +0100, Peter Zijlstra wrote:
> On Wed, 2013-03-06 at 15:06 +0800, Michael Wang wrote:
>
> > wake_affine() stuff is trying to bind related tasks closely, but it doesn't
> > work well according to the test on 'perf bench sched pipe' (thanks to Peter).
>
> so sched-pipe is a poor benchmark for this..
>
> Ideally we'd write a new benchmark that has some actual data footprint
> and we'd measure the cost of tasks being apart on the various cache
> metrics and see what affine wakeup does for it.
>
> Before doing something like what you're proposing, I'd have a hard look
> at WF_SYNC, it is possible we should disable/fix select_idle_sibling
> for sync wakeups.
If nobody beats me to it, I'm going to try tracking shortest round trip
to idle, and use a multiple of that to shut select_idle_sibling() down.
If avg_idle approaches round trip time, there's no win to be had, we're
just wasting cycles.
-Mike
next prev parent reply other threads:[~2013-03-07 9:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 7:06 Michael Wang
2013-03-07 8:36 ` Peter Zijlstra
2013-03-07 9:43 ` Mike Galbraith [this message]
2013-03-08 2:37 ` Michael Wang
2013-03-08 6:44 ` Mike Galbraith
2013-03-08 7:30 ` Michael Wang
2013-03-08 8:26 ` Mike Galbraith
2013-03-11 2:42 ` Michael Wang
2013-03-07 9:46 ` Michael Wang
2013-03-07 16:52 ` Peter Zijlstra
2013-03-08 2:31 ` Michael Wang
2013-03-11 8:21 ` Ingo Molnar
2013-03-11 9:14 ` Michael Wang
2013-03-11 9:40 ` Ingo Molnar
2013-03-12 6:00 ` Michael Wang
2013-03-12 8:48 ` Ingo Molnar
2013-03-12 9:41 ` Michael Wang
2013-03-07 17:21 ` Peter Zijlstra
2013-03-08 2:33 ` Michael Wang
2013-03-07 17:27 ` Peter Zijlstra
2013-03-08 2:50 ` Michael Wang
2013-03-11 10:36 ` Peter Zijlstra
2013-03-12 3:23 ` Michael Wang
2013-03-12 10:08 ` Peter Zijlstra
2013-03-13 3:07 ` Michael Wang
2013-03-14 10:58 ` Peter Zijlstra
2013-03-15 6:24 ` Michael Wang
2013-03-18 3:26 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362649419.4652.12.camel@marge.simpson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pjt@google.com \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome