From: Lokesh Vutla <lokeshvutla@ti.com>
To: <linux-kernel@vger.kernel.org>, <santosh.shilimkar@ti.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Lokesh Vutla <lokeshvutla@ti.com>
Subject: [PATCH 8/8] memory: emif: Load the correct custom config values from dt
Date: Mon, 11 Mar 2013 10:36:05 +0530 [thread overview]
Message-ID: <1362978365-5593-9-git-send-email-lokeshvutla@ti.com> (raw)
In-Reply-To: <1362978365-5593-1-git-send-email-lokeshvutla@ti.com>
of_get_property returns value in Big Endian format.
Before using this value it should be converted to little endian
using be32_to_cpup().
Custom configs of emif are read from dt using of_get_property,
but these are not converted to litte endian format.
Correcting the same here.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
drivers/memory/emif.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 119503a..4866f1b 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -1258,7 +1258,7 @@ static void __init_or_module of_get_custom_configs(struct device_node *np_emif,
{
struct emif_custom_configs *cust_cfgs = NULL;
int len;
- const int *lpmode, *poll_intvl;
+ const __be32 *lpmode, *poll_intvl;
lpmode = of_get_property(np_emif, "low-power-mode", &len);
poll_intvl = of_get_property(np_emif, "temp-alert-poll-interval", &len);
@@ -1272,7 +1272,7 @@ static void __init_or_module of_get_custom_configs(struct device_node *np_emif,
if (lpmode) {
cust_cfgs->mask |= EMIF_CUSTOM_CONFIG_LPMODE;
- cust_cfgs->lpmode = *lpmode;
+ cust_cfgs->lpmode = be32_to_cpup(lpmode);
of_property_read_u32(np_emif,
"low-power-mode-timeout-performance",
&cust_cfgs->lpmode_timeout_performance);
@@ -1287,7 +1287,8 @@ static void __init_or_module of_get_custom_configs(struct device_node *np_emif,
if (poll_intvl) {
cust_cfgs->mask |=
EMIF_CUSTOM_CONFIG_TEMP_ALERT_POLL_INTERVAL;
- cust_cfgs->temp_alert_poll_interval_ms = *poll_intvl;
+ cust_cfgs->temp_alert_poll_interval_ms =
+ be32_to_cpup(poll_intvl);
}
if (of_find_property(np_emif, "extended-temp-part", &len))
--
1.7.9.5
next prev parent reply other threads:[~2013-03-11 5:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 5:05 [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Lokesh Vutla
2013-03-11 5:05 ` [PATCH 1/8] memory: emif: Correct the lpmode timeout calculation Lokesh Vutla
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:05 ` [PATCH 2/8] memory: emif: setup LP settings on freq update Lokesh Vutla
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 3/8] memory: emif: handle overflow for timing for LP mode Lokesh Vutla
2013-03-11 5:35 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 4/8] memory: emif: Handle devices which are not rated for >85C Lokesh Vutla
2013-03-11 5:38 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 5/8] memory: emif: use restart if power_off not present when out of spec Lokesh Vutla
2013-03-11 5:39 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 6/8] memory: emif: fix timings initialization issue Lokesh Vutla
2013-03-11 5:44 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode Lokesh Vutla
2013-03-11 5:50 ` Santosh Shilimkar
2013-03-11 11:10 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla [this message]
2013-03-11 5:51 ` [PATCH 8/8] memory: emif: Load the correct custom config values from dt Santosh Shilimkar
2013-03-15 18:08 ` [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Greg KH
2013-03-16 6:13 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362978365-5593-9-git-send-email-lokeshvutla@ti.com \
--to=lokeshvutla@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®