From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932337Ab3CLJZB (ORCPT ); Tue, 12 Mar 2013 05:25:01 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:39312 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754780Ab3CLJZA (ORCPT ); Tue, 12 Mar 2013 05:25:00 -0400 Message-ID: <1363080296.2401.23.camel@dabdike.int.hansenpartnership.com> Subject: Re: [PATCH] aic7xxx: fix coccicheck warnings From: James Bottomley To: Silviu Popescu Cc: linux-scsi@vger.kernel.org, hare@suse.de, linux-kernel@vger.kernel.org Date: Tue, 12 Mar 2013 09:24:56 +0000 In-Reply-To: References: <1362945896-18475-1-git-send-email-silviupopescu1990@gmail.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.6.3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-03-12 at 08:48 +0200, Silviu Popescu wrote: > On Sun, Mar 10, 2013 at 10:04 PM, Silviu-Mihai Popescu > wrote: > > This replaces a call to kmalloc() followed by memset() with just one > > call to kzalloc(). > > > > Signed-off-by: Silviu-Mihai Popescu > > --- > > drivers/scsi/aic7xxx/aic79xx_osm.c | 3 +-- > > drivers/scsi/aic7xxx/aic7xxx_osm.c | 3 +-- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c > > index 9328121..f6fdb65 100644 > > --- a/drivers/scsi/aic7xxx/aic79xx_osm.c > > +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c > > @@ -1324,10 +1324,9 @@ int > > ahd_platform_alloc(struct ahd_softc *ahd, void *platform_arg) > > { > > ahd->platform_data = > > - kmalloc(sizeof(struct ahd_platform_data), GFP_ATOMIC); > > + kzalloc(sizeof(struct ahd_platform_data), GFP_ATOMIC); > > if (ahd->platform_data == NULL) > > return (ENOMEM); > > - memset(ahd->platform_data, 0, sizeof(struct ahd_platform_data)); > > ahd->platform_data->irq = AHD_LINUX_NOIRQ; > > ahd_lockinit(ahd); > > ahd->seltime = (aic79xx_seltime & 0x3) << 4; > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c > > index 5a477cd..54bb1de 100644 > > --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c > > +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c > > @@ -1222,10 +1222,9 @@ ahc_platform_alloc(struct ahc_softc *ahc, void *platform_arg) > > { > > > > ahc->platform_data = > > - kmalloc(sizeof(struct ahc_platform_data), GFP_ATOMIC); > > + kzalloc(sizeof(struct ahc_platform_data), GFP_ATOMIC); > > if (ahc->platform_data == NULL) > > return (ENOMEM); > > - memset(ahc->platform_data, 0, sizeof(struct ahc_platform_data)); > > ahc->platform_data->irq = AHC_LINUX_NOIRQ; > > ahc_lockinit(ahc); > > ahc->seltime = (aic7xxx_seltime & 0x3) << 4; > > -- > > 1.7.9.5 > > > > Hello, > > Would anyone be so kind as to review this? For the ancient drivers, like aic7xxx, we keep them in deep freeze maintenance, which means no cosmetic changes like this, I'm afraid. Thanks, James