From: Matt Fleming <matt.fleming@intel.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] efivars: Allow disabling use as a pstore backend
Date: Wed, 13 Mar 2013 19:44:33 +0000 [thread overview]
Message-ID: <1363203873.15011.311.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20130313191455.GC12157@thinkpad-t410>
On Wed, 2013-03-13 at 14:14 -0500, Seth Forshee wrote:
> On Wed, Mar 13, 2013 at 06:33:37PM +0000, Matt Fleming wrote:
> > On Wed, 2013-03-13 at 10:25 -0700, H. Peter Anvin wrote:
> > > I think there should be two compile-time options (one to compile in the
> > > EFI pstore code at all, and one to set its default.)
> >
> > OK, sorry Seth, looks like I'm the one that misunderstood. I've picked
> > up your first two patches and pushed them out to the urgent branch.
> > Please check that they look OK - they required minor fixups.
>
> A minor nit from the second patch:
>
> +static bool efivars_pstore_disable = \
> + IS_ENABLED(EFI_VARS_PSTORE_DEFAULT_DISABLE);
>
> The backslash isn't necessary.
Whoops. Fixed.
> Otherwise everything looks fine afaict.
Thanks!
prev parent reply other threads:[~2013-03-13 19:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 17:40 Seth Forshee
2013-03-07 20:38 ` H. Peter Anvin
2013-03-07 20:59 ` Seth Forshee
2013-03-07 22:15 ` Matt Fleming
2013-03-07 22:17 ` H. Peter Anvin
2013-03-11 21:17 ` Seth Forshee
2013-03-12 19:54 ` Matt Fleming
2013-03-12 21:14 ` Seth Forshee
2013-03-13 15:49 ` Matt Fleming
2013-03-13 17:07 ` Seth Forshee
2013-03-13 17:25 ` H. Peter Anvin
2013-03-13 18:33 ` Matt Fleming
2013-03-13 19:14 ` Seth Forshee
2013-03-13 19:44 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363203873.15011.311.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®