From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754029Ab3CNFwY (ORCPT ); Thu, 14 Mar 2013 01:52:24 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:47416 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686Ab3CNFwX (ORCPT ); Thu, 14 Mar 2013 01:52:23 -0400 X-IronPort-AV: E=Sophos;i="4.84,843,1355126400"; d="scan'208";a="29560064" From: Stephen Boyd To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Whitcroft , Joe Perches Subject: [PATCH] checkpatch: Complain about more executable files Date: Wed, 13 Mar 2013 22:52:19 -0700 Message-Id: <1363240339-18327-1-git-send-email-sboyd@codeaurora.org> X-Mailer: git-send-email 1.8.2.rc2.4.g7799588 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't want executable permissions set on files such as devicetree syntax files, text files, defconfig files, or binary hex files. Cc: Andy Whitcroft Cc: Joe Perches Signed-off-by: Stephen Boyd --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b28cc38..591867e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1576,7 +1576,7 @@ sub process { # Check for incorrect file permissions if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { my $permhere = $here . "FILE: $realfile\n"; - if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) { + if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl|\.dts|\.dtsi|defconfig|\.txt|\.hex|\.HEX|\.ihex)$/) { ERROR("EXECUTE_PERMISSIONS", "do not set execute permissions for source files\n" . $permhere); } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation