mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: <dwmw2@infradead.org>
Cc: <artem.bityutskiy@linux.intel.com>, <computersforpeace@gmail.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	Huang Shijie <b32955@freescale.com>
Subject: [PATCH v6 0/3] mtd: use the full-id as the keyword for some nand chips
Date: Fri, 15 Mar 2013 11:00:58 +0800	[thread overview]
Message-ID: <1363316461-10592-1-git-send-email-b32955@freescale.com> (raw)

As time goes on, we begin to meet the situation that we can not
get enough information from some nand chips's id data.
Take some Toshiba's nand chips for example.
I have 4 Toshiba's nand chips in my hand:
	TC58NVG2S0F, TC58NVG3S0F, TC58NVG5D2, TC58NVG6D2

When we read these chips' datasheets, we will get the geometry of these chips:
	TC58NVG2S0F : 4096 + 224
	TC58NVG3S0F : 4096 + 232
	TC58NVG5D2  : 8192 + 640
	TC58NVG6D2  : 8192 + 640

But we can not parse out the correct oob size for these chips from the id data.
So it is time to add some new fields to the nand_flash_dev{},
and update the detection mechanisms.

v5 --> v6:
	[1] add back the id_len as Brian's suggest.
	[2] use id_len to check the full id nand or not.
	[3] change the new fields oob_size/id_len to "uint16_t" type.
	[4] misc

v4 --> v5:
	[1] remove the id_len field.
	[2] based on Artem "mtd: nand: use more reasonable integer types"
	[3] add more comments.

v3 --> v4:
	[1] rewrite the code based on the latest l2-mtd.
	[2] add the full-id nand in the nand_flash_lds.

v2 --> v3:
	[1] remove the duplicated header.
	[2] remove the field "ecc_len" in nand_flash_dev{}.
	[3] fix some coding style warnings.
	[4] add more comments

Huang Shijie (3):
  mtd: add new fields to nand_flash_dev{}
  mtd: add the support to parse out the full-id nand type
  mtd: add 4 Toshiba nand chips for the full-id case

 drivers/mtd/nand/nand_base.c |   35 ++++++++++++++++++++++++++++++++---
 drivers/mtd/nand/nand_ids.c  |   19 +++++++++++++++++++
 include/linux/mtd/nand.h     |    4 ++++
 3 files changed, 55 insertions(+), 3 deletions(-)



             reply	other threads:[~2013-03-15  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15  3:00 Huang Shijie [this message]
2013-03-15  3:00 ` [PATCH v6 1/3] mtd: add new fields to nand_flash_dev{} Huang Shijie
2013-03-15  3:01 ` [PATCH v6 2/3] mtd: add the support to parse out the full-id nand type Huang Shijie
2013-03-15  3:01 ` [PATCH v6 3/3] mtd: add 4 Toshiba nand chips for the full-id case Huang Shijie
2013-03-18  7:34 ` [PATCH v6 0/3] mtd: use the full-id as the keyword for some nand chips Brian Norris
2013-03-18  8:37 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363316461-10592-1-git-send-email-b32955@freescale.com \
    --to=b32955@freescale.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome