mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <santosh.shilimkar@ti.com>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <lokeshvutla@ti.com>,
	Nishanth Menon <nm@ti.com>
Subject: [PATCH V2 5/8] memory: emif: use restart if power_off not present when out of spec
Date: Sat, 16 Mar 2013 11:46:45 +0530	[thread overview]
Message-ID: <1363414608-7448-6-git-send-email-lokeshvutla@ti.com> (raw)
In-Reply-To: <1363414608-7448-1-git-send-email-lokeshvutla@ti.com>

From: Nishanth Menon <nm@ti.com>

Some machine or kernel variants might have missed implementation
of power off handlers. We DONOT want to let the system be in
"out of spec" state in this condition. So, WARN and attempt
a machine restart in the hopes of clearing the out-of-spec
temperature condition.

NOTE: This is not the safest option, but safer than leaving the
system in unstable conditions.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
Changes since V1:
	Added a new extra line before if condition.

 drivers/memory/emif.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 827eb3b..8db74e4 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -25,6 +25,7 @@
 #include <linux/module.h>
 #include <linux/list.h>
 #include <linux/spinlock.h>
+#include <linux/pm.h>
 #include <memory/jedec_ddr.h>
 #include "emif.h"
 #include "of_memory.h"
@@ -1015,7 +1016,14 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
 
 	if (emif->temperature_level == SDRAM_TEMP_VERY_HIGH_SHUTDOWN) {
 		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
-		kernel_power_off();
+
+		/* If we have Power OFF ability, use it, else try restarting */
+		if (pm_power_off) {
+			kernel_power_off();
+		} else {
+			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
+			kernel_restart("SDRAM Over-temp Emergency restart");
+		}
 		return IRQ_HANDLED;
 	}
 
-- 
1.7.9.5


  parent reply	other threads:[~2013-03-16  6:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-16  6:16 [PATCH V2 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Lokesh Vutla
2013-03-16  6:16 ` [PATCH V2 1/8] memory: emif: Fix the lpmode timeout calculation Lokesh Vutla
2013-03-16  6:16 ` [PATCH V2 2/8] memory: emif: setup LP settings on freq update Lokesh Vutla
2013-03-16  6:16 ` [PATCH V2 3/8] memory: emif: handle overflow for timing for LP mode Lokesh Vutla
2013-03-16  6:16 ` [PATCH V2 4/8] memory: emif: Handle devices which are not rated for >85C Lokesh Vutla
2013-03-16  6:16 ` Lokesh Vutla [this message]
2013-03-16  6:16 ` [PATCH V2 6/8] memory: emif: Fix the incorrect 'size' parameter in memcpy Lokesh Vutla
2013-03-16  6:16 ` [PATCH V2 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode Lokesh Vutla
2013-03-16  6:16 ` [PATCH V2 8/8] memory: emif: Load the correct custom config values from dt Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363414608-7448-6-git-send-email-lokeshvutla@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®