From: Venu Byravarasu <vbyravarasu@nvidia.com>
To: <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>,
<balbi@ti.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<swarren@wwwdotorg.org>, <linux-tegra@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
Venu Byravarasu <vbyravarasu@nvidia.com>
Subject: [PATCH 4/7] usb: phy: tegra: Return correct error value provided by clk_get_sys
Date: Mon, 18 Mar 2013 17:59:38 +0530 [thread overview]
Message-ID: <1363609781-4045-5-git-send-email-vbyravarasu@nvidia.com> (raw)
In-Reply-To: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com>
In case if clk_get_sys fails, return correct error value provided by
the API.
Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
drivers/usb/phy/tegra_usb_phy.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
index 93abd68..b5b2037 100644
--- a/drivers/usb/phy/tegra_usb_phy.c
+++ b/drivers/usb/phy/tegra_usb_phy.c
@@ -620,8 +620,7 @@ static int tegra_phy_init(struct usb_phy *x)
phy->clk = clk_get_sys(NULL, ulpi_config->clk);
if (IS_ERR(phy->clk)) {
pr_err("%s: can't get ulpi clock\n", __func__);
- err = -ENXIO;
- goto err1;
+ return PTR_ERR(phy->clk);
}
if (!gpio_is_valid(ulpi_config->reset_gpio))
ulpi_config->reset_gpio =
--
1.7.0.4
next prev parent reply other threads:[~2013-03-18 12:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 12:29 [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver Venu Byravarasu
2013-03-18 12:29 ` [PATCH 1/7] ARM: tegra: finalize USB EHCI and PHY bindings Venu Byravarasu
2013-03-20 11:19 ` kishon
2013-03-20 12:15 ` Venu Byravarasu
2013-03-20 17:30 ` Stephen Warren
2013-03-18 12:29 ` [PATCH 2/7] ARM: tegra: update device trees for USB binding rework Venu Byravarasu
2013-03-19 19:53 ` Stephen Warren
2013-03-20 12:20 ` Venu Byravarasu
2013-04-03 19:38 ` Stephen Warren
2013-03-20 11:23 ` kishon
2013-03-20 12:17 ` Venu Byravarasu
2013-03-20 12:24 ` Felipe Balbi
2013-03-20 12:30 ` Venu Byravarasu
2013-03-20 17:31 ` Stephen Warren
2013-03-18 12:29 ` [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT Venu Byravarasu
2013-03-19 19:58 ` Stephen Warren
2013-03-20 12:24 ` Venu Byravarasu
2013-03-18 12:29 ` Venu Byravarasu [this message]
2013-03-18 12:29 ` [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info " Venu Byravarasu
2013-03-18 13:01 ` Sergei Shtylyov
2013-03-19 4:12 ` Venu Byravarasu
2013-03-19 20:03 ` Stephen Warren
2013-03-18 12:29 ` [PATCH 6/7] usb: phy: tegra: Add error handling & clean up Venu Byravarasu
2013-03-19 19:25 ` Stephen Warren
2013-03-19 20:10 ` Stephen Warren
2013-04-03 19:34 ` Stephen Warren
2013-03-18 12:29 ` [PATCH 7/7] usb: phy: registering tegra USB PHY as platform driver Venu Byravarasu
2013-03-19 20:21 ` Stephen Warren
2013-03-20 12:43 ` Venu Byravarasu
2013-03-20 17:51 ` Stephen Warren
2013-03-19 19:51 ` [PATCH 0/7] USB: PHY: Tegra: registering TEGRA " Stephen Warren
2013-03-20 5:59 ` Venu Byravarasu
2013-03-20 12:12 ` Venu Byravarasu
2013-03-20 17:36 ` Stephen Warren
2013-03-20 18:52 ` Stephen Warren
2013-04-03 19:47 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363609781-4045-5-git-send-email-vbyravarasu@nvidia.com \
--to=vbyravarasu@nvidia.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®