From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, jolsa@redhat.com,
fweisbec@gmail.com
Subject: Re: [PATCH] perf: fix ring_buffer perf_output_space() boundary calculation
Date: Mon, 18 Mar 2013 13:59:29 +0100 [thread overview]
Message-ID: <1363611569.22553.10.camel@laptop> (raw)
In-Reply-To: <20130318124847.GA2491@quad>
On Mon, 2013-03-18 at 13:48 +0100, Stephane Eranian wrote:
> if (!rb->writable)
> - return true;
> + return false;
writable means user writable (VM_WRITE); the difference is that a
!VM_WRITE buffer will simply over-write its own tail whereas a VM_WRITE
buffer will drop events.
So returning true for !VM_WRITE makes sense, there's always space.
next prev parent reply other threads:[~2013-03-18 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 12:48 Stephane Eranian
2013-03-18 12:59 ` Peter Zijlstra [this message]
2013-03-18 13:03 ` Stephane Eranian
2013-03-18 13:11 ` Peter Zijlstra
2013-03-18 13:18 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363611569.22553.10.camel@laptop \
--to=peterz@infradead.org \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®