From: Paul Bolle <pebolle@tiscali.nl>
To: Kees Cook <keescook@chromium.org>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL
Date: Mon, 18 Mar 2013 16:42:11 +0100 [thread overview]
Message-ID: <1363621331.1335.176.camel@x61.thuisdomein> (raw)
In-Reply-To: <CAGXu5jLfq-AqkTyoZRdcJ-S07h0pFKBXDL=KBi7-nT7NQtftKg@mail.gmail.com>
On Sat, 2013-03-16 at 15:38 -0700, Kees Cook wrote:
> Hrm, I actually think it would be better to change this to ERROR
> instead of WARN.
I figured the main reason to add this warning was to prevent people to
add dependencies on EXPERIMENTAL while you were cleaning the tree, which
could mean you had to redo patches each time that happened.
Anyhow, with EXPERIMENTAL gone, this is just one of the mistakes people
can make in using the kconfig system. I'm not sure that we should use
checkpatch to catch these. For this particular case it must also be
noted that if code gets in while still depending on EXPERIMENTAL someone
also missed that this code doesn't get build at all.
Paul Bolle
prev parent reply other threads:[~2013-03-18 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 21:30 Paul Bolle
2013-03-16 22:13 ` Greg Kroah-Hartman
2013-03-16 22:38 ` Kees Cook
2013-03-18 15:42 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363621331.1335.176.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®