From: Dong Hao <haodong@linux.vnet.ibm.com>
To: gregkh@linuxfoundation.org
Cc: xiaoguangrong@linux.vnet.ibm.com, shangw@linux.vnet.ibm.com,
weiyang@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
Dong Hao <haodong@linux.vnet.ibm.com>
Subject: [PATCH 3/3] lib/kobject: WARN_ON corresponds to BUG_ON
Date: Tue, 19 Mar 2013 14:47:01 +0800 [thread overview]
Message-ID: <1363675621-31186-3-git-send-email-haodong@linux.vnet.ibm.com> (raw)
In-Reply-To: <1363675621-31186-1-git-send-email-haodong@linux.vnet.ibm.com>
From: Dong Hao <haodong@linux.vnet.ibm.com>
WARN_ON corresponds to BUG_ON and also gets more info.
Signed-off-by: Dong Hao <haodong@linux.vnet.ibm.com>
---
lib/kobject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/kobject.c b/lib/kobject.c
index ff9b3c3..f7d9f31 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -281,7 +281,7 @@ void kobject_init(struct kobject *kobj, struct kobj_type *ktype)
/* do not error out as sometimes we can recover */
printk(KERN_ERR "kobject (%p): tried to init an initialized "
"object, something is seriously wrong.\n", kobj);
- dump_stack();
+ WARN_ON(1);
}
kobject_init_internal(kobj);
--
1.7.9.5
next prev parent reply other threads:[~2013-03-19 6:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 6:46 [PATCH 1/3] lib/kobject: simplify the kobject_init function Dong Hao
2013-03-19 6:47 ` [PATCH 2/3] lib/kobject: Panic when kobj or ktype is not properly assigned Dong Hao
2013-03-19 6:58 ` Xiao Guangrong
2013-03-19 13:29 ` Greg KH
2013-03-19 6:47 ` Dong Hao [this message]
2013-03-19 7:03 ` [PATCH 3/3] lib/kobject: WARN_ON corresponds to BUG_ON Xiao Guangrong
2013-03-19 7:05 ` Xiao Guangrong
2013-03-19 13:31 ` Greg KH
2013-03-19 13:31 ` [PATCH 1/3] lib/kobject: simplify the kobject_init function Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363675621-31186-3-git-send-email-haodong@linux.vnet.ibm.com \
--to=haodong@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=weiyang@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome