mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 1/3] kernel/srcu: merge common code into a macro
Date: Tue, 19 Mar 2013 09:22:40 -0700	[thread overview]
Message-ID: <1363710160.1932.49.camel@joe-AO722> (raw)
In-Reply-To: <1363702606-31586-1-git-send-email-bigeasy@linutronix.de>

On Tue, 2013-03-19 at 15:16 +0100, Sebastian Andrzej Siewior wrote:
> DEFINE_SRCU() and DEFINE_STATIC_SRCU() does the same thing except for
> the "static" attribute. This patch moves the common pieces into
> _DEFINE_SRCU() which is used by the the former macros either adding the
> static attribute or not.
[]
> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
[]
> +#define DEFINE_SRCU(name)		_DEFINE_SRCU(name, )
> +#define DEFINE_STATIC_SRCU(name)	_DEFINE_SRCU(name, static)

I think the use of an empty argument, even in
a macro, unsightly.



  parent reply	other threads:[~2013-03-19 16:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 14:16 Sebastian Andrzej Siewior
2013-03-19 14:16 ` [PATCH 2/3] kernel/SRCU: provide a static initializer Sebastian Andrzej Siewior
2013-04-05  7:21   ` Lai Jiangshan
2013-04-08 10:03     ` Sebastian Andrzej Siewior
2013-04-09  1:09       ` Lai Jiangshan
2013-04-11 17:04         ` Sebastian Andrzej Siewior
2013-04-12  2:56           ` Lai Jiangshan
2013-04-16 18:20             ` Paul E. McKenney
2013-03-19 14:16 ` [PATCH 3/3] cpufreq: use static initializer for the SRCU notifier Sebastian Andrzej Siewior
2013-03-19 16:22 ` Joe Perches [this message]
2013-03-19 18:15   ` [PATCH 1/3] kernel/srcu: merge common code into a macro Sebastian Andrzej Siewior
2013-04-05  7:21 ` Lai Jiangshan
2013-04-08 10:05   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363710160.1932.49.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=bigeasy@linutronix.de \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®