From: Richard Genoud <richard.genoud@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Axel Lin <axel.lin@ingics.com>,
Stephen Warren <swarren@nvidia.com>,
linux-kernel@vger.kernel.org,
Richard Genoud <richard.genoud@gmail.com>
Subject: [PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX
Date: Wed, 20 Mar 2013 12:31:52 +0100 [thread overview]
Message-ID: <1363779113-8776-2-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1363779113-8776-1-git-send-email-richard.genoud@gmail.com>
If pin_free is called on a pin already freed, mux_usecount is set to
UINT_MAX which is really a bad idea.
This will silently ignore a double call to pin_free
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/pinctrl/pinmux.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 917e830..9fd55f9 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -194,8 +194,9 @@ static const char *pin_free(struct pinctrl_dev *pctldev, int pin,
}
if (!gpio_range) {
- desc->mux_usecount--;
- if (desc->mux_usecount)
+ if (1 == desc->mux_usecount)
+ desc->mux_usecount = 0;
+ else
return NULL;
}
--
1.7.2.5
next prev parent reply other threads:[~2013-03-20 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 11:31 [PATCH] BUG: pinmux: release only taken pins on error Richard Genoud
2013-03-20 11:31 ` Richard Genoud [this message]
2013-03-20 16:14 ` [PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX Stephen Warren
2013-03-20 16:59 ` Richard Genoud
2013-03-20 17:08 ` Stephen Warren
2013-03-21 11:21 ` Richard Genoud
2013-03-21 17:33 ` Stephen Warren
2013-03-21 18:28 ` Linus Walleij
2013-03-20 11:31 ` [PATCH] BUG: [RFC] pinctrl: pins are freed 2 times in pinctrl_bind_pins Richard Genoud
2013-03-20 16:23 ` Stephen Warren
2013-03-21 11:31 ` Richard Genoud
2013-03-20 13:21 ` [PATCH] BUG: pinmux: release only taken pins on error Axel Lin
2013-03-20 14:19 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363779113-8776-2-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome