From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933963Ab3CUQdz (ORCPT ); Thu, 21 Mar 2013 12:33:55 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:26865 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756043Ab3CUQdx (ORCPT ); Thu, 21 Mar 2013 12:33:53 -0400 Message-ID: <1363883628.2736.8.camel@bwh-desktop.uk.solarflarecom.com> Subject: Re: [PATCH net] vhost/net: fix heads usage of ubuf_info From: Ben Hutchings To: "Michael S. Tsirkin" CC: David Miller , , , , , , , , Date: Thu, 21 Mar 2013 16:33:48 +0000 In-Reply-To: <20130321162813.GG1925@redhat.com> References: <20130317124609.GA25967@redhat.com> <20130317.142955.1114572401286297685.davem@davemloft.net> <20130321060218.GB23908@redhat.com> <1363883028.2736.7.camel@bwh-desktop.uk.solarflarecom.com> <20130321162813.GG1925@redhat.com> Organization: Solarflare Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.17.20.137] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-19734.005 X-TM-AS-Result: No--22.915000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2013-03-21 at 18:28 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 21, 2013 at 04:23:48PM +0000, Ben Hutchings wrote: > > On Thu, 2013-03-21 at 08:02 +0200, Michael S. Tsirkin wrote: > > > On Sun, Mar 17, 2013 at 02:29:55PM -0400, David Miller wrote: > > > > From: "Michael S. Tsirkin" > > > > Date: Sun, 17 Mar 2013 14:46:09 +0200 > > > > > > > > > ubuf info allocator uses guest controlled head as an index, > > > > > so a malicious guest could put the same head entry in the ring twice, > > > > > and we will get two callbacks on the same value. > > > > > To fix use upend_idx which is guaranteed to be unique. > > > > > > > > > > Reported-by: Rusty Russell > > > > > Signed-off-by: Michael S. Tsirkin > > > > > > > > Applied and queued up for -stable, thanks. > > > > > > > > And thankfully you got the stable URL wrong, > > > > > > Yes I wrote stable@kernel.org that's what an old copy > > > says here: > > > https://www.kernel.org/doc/Documentation/stable_kernel_rules.txt > > > > > > I should have known better than look at it on the 'net. The top > > > 'Everything you ever wanted to know about Linux 2.6 -stable releases.' > > > is a big hint that it's stale. > > > Any idea who maintains this? Better update it or remove it or redirect to git. > > > > Rob Landley maintains it, but he's been having trouble updating it since > > all the upload mechanisms were changed on kernel.org. > > > > (My stable maintenance scripts still match the old address, anyway. Not > > sure about Greg's.) > > > > Ben. > > I hope you mean it will match both the old and the new address? Yes, of course! Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.