From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Stephen Warren <swarren@wwwdotorg.org>,
Russell King <linux@arm.linux.org.uk>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Simon Glass <sjg@chromium.org>, Rhyland Klein <rklein@nvidia.com>,
Pritesh Raithatha <praithatha@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hiroshi Doyu <hdoyu@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Andrew Chew <achew@nvidia.com>,
Mike Turquette <mturquette@linaro.org>,
Thierry Reding <thierry.reding@avionic-design.de>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v8 04/14] clk: tegra: introduce TEGRA_PLL_HAS_LOCK_ENABLE
Date: Fri, 22 Mar 2013 14:39:21 +0200 [thread overview]
Message-ID: <1363956029-31873-5-git-send-email-pdeschrijver@nvidia.com> (raw)
In-Reply-To: <1363956029-31873-1-git-send-email-pdeschrijver@nvidia.com>
Tegra114 PLLC2 and PLLC3 don't have a lock enable bit. The lock bits are
always functional.
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
drivers/clk/tegra/clk-pll.c | 5 +++++
drivers/clk/tegra/clk.h | 2 ++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 4ee6d03..eaab060 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -108,6 +108,9 @@ static void clk_pll_enable_lock(struct tegra_clk_pll *pll)
if (!(pll->flags & TEGRA_PLL_USE_LOCK))
return;
+ if (!(pll->flags & TEGRA_PLL_HAS_LOCK_ENABLE))
+ return;
+
val = pll_readl_misc(pll);
val |= BIT(pll->params->lock_enable_bit_idx);
pll_writel_misc(val, pll);
@@ -675,6 +678,7 @@ struct clk *tegra_clk_register_pll(const char *name, const char *parent_name,
struct clk *clk;
pll_flags |= TEGRA_PLL_BYPASS;
+ pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE;
pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
freq_table, lock);
if (IS_ERR(pll))
@@ -698,6 +702,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name,
struct clk *clk;
pll_flags |= TEGRA_PLL_LOCK_MISC | TEGRA_PLL_BYPASS;
+ pll_flags |= TEGRA_PLL_HAS_LOCK_ENABLE;
pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
freq_table, lock);
if (IS_ERR(pll))
diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h
index 2697aa8..04049d7 100644
--- a/drivers/clk/tegra/clk.h
+++ b/drivers/clk/tegra/clk.h
@@ -185,6 +185,7 @@ struct tegra_clk_pll_params {
* TEGRA_PLL_LOCK_MISC - Lock bit is in the misc register instead of the
* base register.
* TEGRA_PLL_BYPASS - PLL has bypass bit
+ * TEGRA_PLL_HAS_LOCK_ENABLE - PLL has bit to enable lock monitoring
*/
struct tegra_clk_pll {
struct clk_hw hw;
@@ -215,6 +216,7 @@ struct tegra_clk_pll {
#define TEGRA_PLLE_CONFIGURE BIT(7)
#define TEGRA_PLL_LOCK_MISC BIT(8)
#define TEGRA_PLL_BYPASS BIT(9)
+#define TEGRA_PLL_HAS_LOCK_ENABLE BIT(10)
extern const struct clk_ops tegra_clk_pll_ops;
extern const struct clk_ops tegra_clk_plle_ops;
--
1.7.7.rc0.72.g4b5ea.dirty
next prev parent reply other threads:[~2013-03-22 12:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 12:39 [PATCH v8 00/14] Tegra114 clockframework Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 01/14] clk: tegra: provide dummy cpu car ops Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 02/14] clk: tegra: Refactor PLL programming code Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 03/14] clk: tegra: Add TEGRA_PLL_BYPASS flag Peter De Schrijver
2013-03-22 12:39 ` Peter De Schrijver [this message]
2013-03-22 12:39 ` [PATCH v8 05/14] clk: tegra: Add PLL post divider table Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 06/14] clk: tegra: move from a lock bit idx to a lock mask Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 07/14] clk: tegra: Add new fields and PLL types for Tegra114 Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 08/14] clk: tegra: Add flags to tegra_clk_periph() Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 09/14] clk: tegra: Workaround for Tegra114 MSENC problem Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding Peter De Schrijver
2013-03-25 11:15 ` Prashant Gaikwad
2013-04-03 14:19 ` Peter De Schrijver
2013-04-04 7:14 ` Prashant Gaikwad
2013-03-22 12:39 ` [PATCH v8 11/14] clk: tegra: Implement clocks for Tegra114 Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 12/14] clk: tegra: devicetree match for nvidia,tegra114-car Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 13/14] ARM: dt: Add references to tegra_car clocks Peter De Schrijver
2013-03-22 12:39 ` [PATCH v8 14/14] clk: tegra: Remove forced clk_enable of uartd Peter De Schrijver
2013-03-22 12:55 ` [PATCH v8 00/14] Tegra114 clockframework Peter De Schrijver
2013-03-22 19:05 ` Stephen Warren
2013-03-25 22:44 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363956029-31873-5-git-send-email-pdeschrijver@nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=achew@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hdoyu@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=pgaikwad@nvidia.com \
--cc=praithatha@nvidia.com \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sjg@chromium.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®