From: Yijing Wang <wangyijing@huawei.com>
To: Tony Luck <tony.luck@intel.com>
Cc: <linux-kernel@vger.kernel.org>, Hanjun Guo <guohanjun@huawei.com>,
Yijing Wang <wangyijing@huawei.com>
Subject: [PATCH v5 3/5] PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject
Date: Tue, 26 Mar 2013 10:43:37 +0800 [thread overview]
Message-ID: <1364265819-6732-4-git-send-email-wangyijing@huawei.com> (raw)
In-Reply-To: <1364265819-6732-1-git-send-email-wangyijing@huawei.com>
When we do hot plug for pci devices that were injected aer errors, some newly created child buses'
pci_ops will be assigned to pci_ops_aer. Aer_inject module will not track these pci_ops_aer(not
list in pci_bus_ops_list),so we should clean all of these when rmmod aer_inject module.
Reviewed-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/pci/pcie/aer/aer_inject.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
index f499f01..4777c44 100644
--- a/drivers/pci/pcie/aer/aer_inject.c
+++ b/drivers/pci/pcie/aer/aer_inject.c
@@ -285,6 +285,29 @@ static void pci_bus_ops_init(struct pci_bus_ops *bus_ops,
bus_ops->ops = ops;
}
+static void pci_clean_child_aer_ops(struct pci_bus *bus)
+{
+ struct pci_bus *child;
+
+ list_for_each_entry(child, &bus->children, node) {
+ if (child->ops == &pci_ops_aer)
+ pci_bus_set_ops(child, bus->ops);
+ pci_clean_child_aer_ops(child);
+ }
+}
+
+/* find pci_ops_aer from root bus, and replace it by parent bus's pci_ops.
+ * pci_ops of root bus won't be pci_ops_aer here*/
+static void clean_untracked_pci_ops_aer(void)
+{
+ struct pci_bus_ops *bus_ops;
+
+ list_for_each_entry(bus_ops, &pci_bus_ops_list, list) {
+ if (pci_is_root_bus(bus_ops->bus))
+ pci_clean_child_aer_ops(bus_ops->bus);
+ }
+}
+
static int pci_bus_set_aer_ops(struct pci_bus *bus)
{
struct pci_ops *ops;
@@ -546,6 +569,7 @@ static void __exit aer_inject_exit(void)
list_for_each_entry(bus_ops, &pci_bus_ops_list, list)
pci_bus_set_ops(bus_ops->bus, bus_ops->ops);
+ clean_untracked_pci_ops_aer();
while ((bus_ops = pci_bus_ops_pop()))
kfree(bus_ops);
--
1.7.1
next prev parent reply other threads:[~2013-03-26 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 2:43 [PATCH v5 0/5] Fix aer_inject tool bug Yijing Wang
2013-03-26 2:43 ` [PATCH v5 1/5] PCI/AER: Fix pci_ops return NULL in pci_read/write_aer Yijing Wang
2013-03-26 2:43 ` [PATCH v5 2/5] PCI/AER: use list_for_each_entry to avoid a small race condition window Yijing Wang
2013-03-26 2:43 ` Yijing Wang [this message]
2013-03-26 2:43 ` [PATCH v5 4/5] PCI/AER: clean pci_bus_ops when related pci bus was removed Yijing Wang
2013-03-26 2:43 ` [PATCH v5 5/5] PCI/AER: free pci_bus_ops_list and remove pci_bus_ops_pop Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364265819-6732-4-git-send-email-wangyijing@huawei.com \
--to=wangyijing@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®