mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] ftrace: Consistently restore trace function on sysctl enabling
Date: Tue, 26 Mar 2013 15:55:38 -0400	[thread overview]
Message-ID: <1364327738.6345.198.camel@gandalf.local.home> (raw)
In-Reply-To: <1364325014.6345.195.camel@gandalf.local.home>

On Tue, 2013-03-26 at 15:10 -0400, Steven Rostedt wrote:

> I remember there was a reason why I didn't update this, but I can't
> remember why. Looking at it now, it doesn't look like there is a reason.

I remember now. I didn't add it because the update_ftrace_function was
too much at the time. It was still doing the basic updates, but it was
also doing a bit more too. But this was before I added the extra checks.
I didn't call it because it seemed to be an overkill. But that doesn't
apply today.


> 
> I'll have to think about this one more. Another score for not
> commenting :-p

OK, I'll add it and it looks like it needs to go immediately, as well as
way back to 3.0 stable.

Thanks!

-- Steve



      reply	other threads:[~2013-03-26 19:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 16:53 Jan Kiszka
2013-03-26 19:10 ` Steven Rostedt
2013-03-26 19:55   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364327738.6345.198.camel@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®