mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: seb <sebastien.royen@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Bill Pemberton <wfp5p@virginia.edu>
Cc: linux-kernel@vger.kernel.org, seb <sebastien.royen@armadeus.com>
Subject: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion
Date: Wed, 27 Mar 2013 09:17:43 +0100	[thread overview]
Message-ID: <1364372263-16848-1-git-send-email-sebastien.royen@armadeus.com> (raw)

Event value is wrong. Should be in range -2048 to 2047, but is in range 0 to 4095.
Use int8_t to int conversion and remove 0xfff mask.

Signed-off-by: seb <sebastien.royen@armadeus.com>
---
 drivers/input/misc/mma8450.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
index 480557f..c3781a1 100644
--- a/drivers/input/misc/mma8450.c
+++ b/drivers/input/misc/mma8450.c
@@ -110,7 +110,7 @@ static void mma8450_poll(struct input_polled_dev *dev)
 	struct mma8450 *m = dev->private;
 	int x, y, z;
 	int ret;
-	u8 buf[6];
+	int8_t buf[6];
 
 	ret = mma8450_read(m, MMA8450_STATUS);
 	if (ret < 0)
@@ -119,13 +119,18 @@ static void mma8450_poll(struct input_polled_dev *dev)
 	if (!(ret & MMA8450_STATUS_ZXYDR))
 		return;
 
-	ret = mma8450_read_block(m, MMA8450_OUT_X_LSB, buf, sizeof(buf));
+	ret = mma8450_read_block(m, MMA8450_OUT_X_LSB, (u8*)buf, sizeof(buf));
 	if (ret < 0)
 		return;
 
-	x = ((buf[1] << 4) & 0xff0) | (buf[0] & 0xf);
-	y = ((buf[3] << 4) & 0xff0) | (buf[2] & 0xf);
-	z = ((buf[5] << 4) & 0xff0) | (buf[4] & 0xf);
+	/* convert 8 MSB from int8_t to int */
+	x = buf[1];
+	y = buf[3];
+	z = buf[5];
+	/* add 4 LSB */
+	x = (x << 4) | (buf[0] & 0xf);
+	y = (y << 4) | (buf[2] & 0xf);
+	z = (z << 4) | (buf[4] & 0xf);
 
 	input_report_abs(dev->input, ABS_X, x);
 	input_report_abs(dev->input, ABS_Y, y);
-- 
1.7.9.5


             reply	other threads:[~2013-03-27  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  8:17 seb [this message]
2013-03-28  5:58 ` Dmitry Torokhov
2013-03-28  7:36   ` Sebastien Royen
2013-03-28  8:14     ` Dmitry Torokhov
2013-03-28 14:16 Sebastien Royen
2013-03-31  7:25 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364372263-16848-1-git-send-email-sebastien.royen@armadeus.com \
    --to=sebastien.royen@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastien.royen@armadeus.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®