From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756018Ab3C1H7E (ORCPT ); Thu, 28 Mar 2013 03:59:04 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:53645 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755224Ab3C1H7C (ORCPT ); Thu, 28 Mar 2013 03:59:02 -0400 X-AuditID: 9c930197-b7c9dae000006959-92-5153f8422a35 From: Joonsoo Kim To: Ingo Molnar , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Mike Galbraith , Paul Turner , Alex Shi , Preeti U Murthy , Vincent Guittot , Morten Rasmussen , Namhyung Kim , Joonsoo Kim Subject: [PATCH 1/5] sched: remove one division operation in find_buiest_queue() Date: Thu, 28 Mar 2013 16:58:52 +0900 Message-Id: <1364457537-15114-2-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1364457537-15114-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1364457537-15114-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove one division operation in find_buiest_queue(). Signed-off-by: Joonsoo Kim diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6f238d2..1d8774f 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4911,7 +4911,7 @@ static struct rq *find_busiest_queue(struct lb_env *env, struct sched_group *group) { struct rq *busiest = NULL, *rq; - unsigned long max_load = 0; + unsigned long busiest_load = 0, busiest_power = SCHED_POWER_SCALE; int i; for_each_cpu(i, sched_group_cpus(group)) { @@ -4942,10 +4942,9 @@ static struct rq *find_busiest_queue(struct lb_env *env, * the load can be moved away from the cpu that is potentially * running at a lower capacity. */ - wl = (wl * SCHED_POWER_SCALE) / power; - - if (wl > max_load) { - max_load = wl; + if (wl * busiest_power > busiest_load * power) { + busiest_load = wl; + busiest_power = power; busiest = rq; } } -- 1.7.9.5