From: Paul Bolle <pebolle@tiscali.nl>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines
Date: Mon, 01 Apr 2013 21:31:38 +0200 [thread overview]
Message-ID: <1364844698.21627.83.camel@x61.thuisdomein> (raw)
In-Reply-To: <alpine.LNX.2.00.1303311746490.22069@pobox.suse.cz>
On Sun, 2013-03-31 at 17:47 +0200, Jiri Kosina wrote:
> I believe you could remove all the corresponding major number defines from
> include/uapi/linux/major.h while you are at it.
0) You seem to mean these:
$ grep VIO include/uapi/linux/major.h
#define VIODASD_MAJOR 112
#define VIOCD_MAJOR 113
#define VIOTAPE_MAJOR 230
They are indeed unused. But are they safe to be removed? I'm always very
cautious with touching magic numbers, and the like (even obsolete).
1) Anyhow, if they really can be removed, I prefer to do that in a
separate patch.
Paul Bolle
prev parent reply other threads:[~2013-04-01 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 14:48 Paul Bolle
2013-03-31 15:47 ` Jiri Kosina
2013-04-01 19:31 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364844698.21627.83.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®