From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>
Subject: [PATCH 08/10] perf top: Use sort__has_sym
Date: Wed, 3 Apr 2013 21:26:17 +0900 [thread overview]
Message-ID: <1364991979-3008-9-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1364991979-3008-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
perf top had a similar variable sort_has_symbols for the same purpose.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-top.c | 12 +++---------
tools/perf/util/top.h | 1 -
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 9aae3f518f39..4aa504baaf0b 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -794,7 +794,7 @@ static void perf_event__process_sample(struct perf_tool *tool,
return;
}
- if (top->sort_has_symbols)
+ if (sort__has_sym)
perf_top__record_precise_ip(top, he, evsel->idx, ip);
}
@@ -912,9 +912,9 @@ out_err:
return -1;
}
-static int perf_top__setup_sample_type(struct perf_top *top)
+static int perf_top__setup_sample_type(struct perf_top *top __maybe_unused)
{
- if (!top->sort_has_symbols) {
+ if (!sort__has_sym) {
if (symbol_conf.use_callchain) {
ui__error("Selected -g but \"sym\" not present in --sort/-s.");
return -EINVAL;
@@ -1205,12 +1205,6 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
sort_entry__setup_elide(&sort_comm, symbol_conf.comm_list, "comm", stdout);
sort_entry__setup_elide(&sort_sym, symbol_conf.sym_list, "symbol", stdout);
- /*
- * Avoid annotation data structures overhead when symbols aren't on the
- * sort list.
- */
- top.sort_has_symbols = sort_sym.list.next != NULL;
-
get_term_dimensions(&top.winsize);
if (top.print_entries == 0) {
struct sigaction act = {
diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h
index 7ebf357dc9e1..f0a862539ba9 100644
--- a/tools/perf/util/top.h
+++ b/tools/perf/util/top.h
@@ -26,7 +26,6 @@ struct perf_top {
int print_entries, count_filter, delay_secs;
bool hide_kernel_symbols, hide_user_symbols, zero;
bool use_tui, use_stdio;
- bool sort_has_symbols;
bool kptr_restrict_warned;
bool vmlinux_warned;
bool dump_symtab;
--
1.7.11.7
next prev parent reply other threads:[~2013-04-03 12:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 12:26 [PATCHSET 00/10] perf tools: Cleanup for sort keys (v2) Namhyung Kim
2013-04-03 12:26 ` [PATCH 01/10] perf sort: Factor out common code in sort_dimension__add() Namhyung Kim
2013-05-31 11:19 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-04-03 12:26 ` [PATCH 02/10] perf sort: Separate out memory-specific sort keys Namhyung Kim
2013-05-31 11:20 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-06-25 0:30 ` Andi Kleen
2013-06-25 1:00 ` Namhyung Kim
2013-06-25 1:02 ` Andi Kleen
2013-06-25 1:06 ` Namhyung Kim
2013-04-03 12:26 ` [PATCH 03/10] perf sort: Add 'addr' sort key Namhyung Kim
2013-04-03 17:06 ` Arnaldo Carvalho de Melo
2013-04-04 0:49 ` Namhyung Kim
2013-04-03 12:26 ` [PATCH 04/10] perf sort: Add 'addr_to/from' " Namhyung Kim
2013-04-03 12:26 ` [PATCH 05/10] perf sort: Update documentation for sort keys Namhyung Kim
2013-04-03 12:26 ` [PATCH 06/10] perf hists: Move column length setting code Namhyung Kim
2013-04-03 12:26 ` [PATCH 07/10] perf sort: Cleanup sort__has_sym setting Namhyung Kim
2013-04-03 12:26 ` Namhyung Kim [this message]
2013-04-03 12:26 ` [PATCH 09/10] perf hist browser: Use sort__has_sym Namhyung Kim
2013-04-03 17:07 ` Arnaldo Carvalho de Melo
2013-04-04 0:55 ` Namhyung Kim
2013-04-03 12:26 ` [PATCH 10/10] perf sort: Consolidate sort_entry__setup_elide() Namhyung Kim
2013-04-03 17:09 ` Arnaldo Carvalho de Melo
2013-04-04 0:56 ` Namhyung Kim
2013-05-31 11:21 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364991979-3008-9-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome