mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Jean Delvare <khali@linux-fr.org>,
	Guenter Roeck <linux@roeck-us.net>,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Blackfin: bf537: use "CONFIG_SND_SOC_AD193X"
Date: Fri, 05 Apr 2013 11:20:46 +0200	[thread overview]
Message-ID: <1365153646.1830.58.camel@x61.thuisdomein> (raw)

Commit 57084ede395bb3c9da7905701d34a3b7d33c9356 ("blackfin: bf537:
stamp: update board file for 193x") changed two references to
CONFIG_SND_BF5XX_SOC_AD193X (and CONFIG_SND_BF5XX_SOC_AD193X_MODULE).
One was changed to CONFIG_SND_SOC_AD193X_SPI, the other to
CONFIG_SND_SOC_AD193X_I2C. The commit explanation doesn't elaborate on
the reason for these changes nor on the reason to drop module support.

Anyhow, neither of these two new Kconfig macros is valid. It was
probably intended to use CONFIG_SND_SOC_AD193X here. So let's use that.
And let's also reenable module support by using the IS_ENABLED() macro.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested. Please note that I fail to see the point of commit
57084ede395bb3c9da7905701d34a3b7d33c9356, which was added in v3.4, even
if I assume it wanted to use CONFIG_SND_SOC_AD193X. Perhaps I'm missing
something obvious. Anyhow, review is appreciated.

1) Added Jean and Guenter because they seem to take in interest in
Blackfin's stamp files.

 arch/blackfin/mach-bf537/boards/stamp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
index e6fdc2a..94a193e 100644
--- a/arch/blackfin/mach-bf537/boards/stamp.c
+++ b/arch/blackfin/mach-bf537/boards/stamp.c
@@ -975,7 +975,7 @@ static struct spi_board_info bfin_spi_board_info[] __initdata = {
 	},
 #endif
 
-#ifdef CONFIG_SND_SOC_AD193X_SPI
+#if IS_ENABLED(CONFIG_SND_SOC_AD193X)
 	{
 		.modalias = "ad193x",
 		.max_speed_hz = 3125000,     /* max spi clock (SCK) speed in HZ */
@@ -2176,7 +2176,7 @@ static unsigned long adt7316_i2c_data[2] = {
 #endif
 
 static struct i2c_board_info __initdata bfin_i2c_board_info[] = {
-#ifdef CONFIG_SND_SOC_AD193X_I2C
+#if IS_ENABLED(CONFIG_SND_SOC_AD193X)
 	{
 		I2C_BOARD_INFO("ad1937", 0x04),
 	},
-- 
1.7.11.7


             reply	other threads:[~2013-04-05  9:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05  9:20 Paul Bolle [this message]
2013-04-05  9:43 ` Jean Delvare
2013-04-05 14:28   ` Guenter Roeck
2014-02-13 10:22 ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365153646.1830.58.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®