From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alessio Igor Bogani <abogani@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Christoph Lameter <cl@linux.com>,
Geoff Levand <geoff@infradead.org>,
Gilad Ben Yossef <gilad@benyossef.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Li Zhong <zhong@linux.vnet.ibm.com>,
Namhyung Kim <namhyung.kim@lge.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Turner <pjt@google.com>, Mike Galbraith <efault@gmx.de>
Subject: [PATCH 5/7] sched: Update rq clock before idle balancing
Date: Sat, 6 Apr 2013 18:45:58 +0200 [thread overview]
Message-ID: <1365266760-24725-6-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1365266760-24725-1-git-send-email-fweisbec@gmail.com>
idle_balance() is called from schedule() right before we schedule the
idle task. It needs to record the idle timestamp at that time and for
this the rq clock must be accurate. If the CPU is running tickless
we need to update the rq clock manually.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Geoff Levand <geoff@infradead.org>
Cc: Gilad Ben Yossef <gilad@benyossef.com>
Cc: Hakan Akkan <hakanakkan@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Paul Turner <pjt@google.com>
Cc: Mike Galbraith <efault@gmx.de>
---
kernel/sched/fair.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fdff363..f90e1d8 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5216,6 +5216,7 @@ void idle_balance(int this_cpu, struct rq *this_rq)
int pulled_task = 0;
unsigned long next_balance = jiffies + HZ;
+ update_nohz_rq_clock(this_rq);
this_rq->idle_stamp = this_rq->clock;
if (this_rq->avg_idle < sysctl_sched_migration_cost)
--
1.7.5.4
next prev parent reply other threads:[~2013-04-06 16:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 16:45 [RFC GIT PULL] nohz: Full dynticks rq clock handling Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 1/7] sched: Update rq clock on nohz CPU before migrating tasks Frederic Weisbecker
2013-04-08 11:48 ` Ingo Molnar
2013-04-09 9:13 ` Peter Zijlstra
2013-04-09 13:11 ` Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 2/7] sched: Update rq clock on nohz CPU before setting fair group shares Frederic Weisbecker
2013-04-09 9:26 ` Peter Zijlstra
2013-04-09 13:21 ` Frederic Weisbecker
2013-04-10 7:05 ` Peter Zijlstra
2013-04-10 10:06 ` Ingo Molnar
2013-04-10 11:02 ` Peter Zijlstra
2013-04-10 11:06 ` Ingo Molnar
2013-04-10 11:47 ` Peter Zijlstra
2013-04-10 11:50 ` Ingo Molnar
2013-04-06 16:45 ` [PATCH 3/7] sched: Update rq clock on tickless CPUs before calling check_preempt_curr() Frederic Weisbecker
2013-04-09 13:18 ` Peter Zijlstra
2013-04-09 16:53 ` Frederic Weisbecker
2013-04-06 16:45 ` [PATCH 4/7] sched: Update rq clock earlier in unthrottle_cfs_rq Frederic Weisbecker
2013-04-06 16:45 ` Frederic Weisbecker [this message]
2013-04-06 16:45 ` [PATCH 6/7] sched: Use an accessor to read rq clock Frederic Weisbecker
2013-04-06 16:46 ` [PATCH 7/7] sched: Debug nohz " Frederic Weisbecker
2013-04-10 10:26 ` [RFC GIT PULL] nohz: Full dynticks rq clock handling Peter Zijlstra
2013-04-10 10:29 ` Ingo Molnar
2013-04-11 15:11 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365266760-24725-6-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=abogani@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=efault@gmx.de \
--cc=geoff@infradead.org \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®