Re: [PATCH] F2FS: Fix the logic of IS_DNODE()

[Jaegeuk Kim <jaegeuk.kim@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Hi,

2013-04-07 (일), 12:57 -0400, Zhihui Zhang:
> Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
> ---
>  fs/f2fs/node.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
> index afdb130..2be47b2 100644
> --- a/fs/f2fs/node.h
> +++ b/fs/f2fs/node.h
> @@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
>  		return false;
>  	if (ofs >= 6 + 2 * NIDS_PER_BLOCK) {
>  		ofs -= 6 + 2 * NIDS_PER_BLOCK;
> -		if ((long int)ofs % (NIDS_PER_BLOCK + 1))
> +		if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))

Great catch!
I'll apply this.
Thank you.

>  			return false;
>  	}
>  	return true;

-- 
Jaegeuk Kim
Samsung


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]