From: Hector Palacios <hector.palacios@digi.com>
To: <linux-kernel@vger.kernel.org>
Cc: <maxime.ripard@free-electrons.com>, <marex@denx.de>,
<shawn.guo@linaro.org>, <fabio.estevam@freescale.com>,
<hector.palacios@digi.com>
Subject: [PATCH RFC] ARM: dts: mxs: leave card detect out of common mmc pins config
Date: Mon, 8 Apr 2013 12:12:20 +0200 [thread overview]
Message-ID: <1365415940-11609-1-git-send-email-hector.palacios@digi.com> (raw)
MicroSD card sockets don't usually have card detect line. This pin
is actually not needed for the MMC to work and it is more of a
platform design decission to have it.
The card detect pin already has a configuration entry of its own:
'mmc0_cd_cfg' so we complete the iomux configuration here and let
platforms to include it or not depending on whether the card detect
line is routed to the SD socket.
Signed-off-by: Hector Palacios <hector.palacios@digi.com>
---
Hello,
All imx28 based platforms except 'bluegiga,apx4devkit' and
'schulercontrol,imx28-sps1', use 'mmc0_cd_cfg' in their mmc configuration
so please check whether this patch would break these platforms.
arch/arm/boot/dts/imx28.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 9b18e81..4222e4e 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -449,7 +449,6 @@
0x2060 /* MX28_PAD_SSP0_DATA6__SSP0_D6 */
0x2070 /* MX28_PAD_SSP0_DATA7__SSP0_D7 */
0x2080 /* MX28_PAD_SSP0_CMD__SSP0_CMD */
- 0x2090 /* MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT */
0x20a0 /* MX28_PAD_SSP0_SCK__SSP0_SCK */
>;
fsl,drive-strength = <1>;
@@ -465,7 +464,6 @@
0x2020 /* MX28_PAD_SSP0_DATA2__SSP0_D2 */
0x2030 /* MX28_PAD_SSP0_DATA3__SSP0_D3 */
0x2080 /* MX28_PAD_SSP0_CMD__SSP0_CMD */
- 0x2090 /* MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT */
0x20a0 /* MX28_PAD_SSP0_SCK__SSP0_SCK */
>;
fsl,drive-strength = <1>;
@@ -477,6 +475,8 @@
fsl,pinmux-ids = <
0x2090 /* MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT */
>;
+ fsl,drive-strength = <1>;
+ fsl,voltage = <1>;
fsl,pull-up = <0>;
};
--
1.8.2
next reply other threads:[~2013-04-08 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 10:12 Hector Palacios [this message]
2013-04-08 12:48 ` Shawn Guo
2013-04-08 13:58 ` Hector Palacios
2013-04-08 14:50 ` Shawn Guo
2013-04-08 16:28 ` Marek Vasut
2013-04-09 7:18 ` Hector Palacios
2013-04-09 8:15 ` Marek Vasut
2013-04-09 9:00 ` Hector Palacios
2013-04-09 10:51 ` Marek Vasut
2013-04-10 8:56 ` Hector Palacios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365415940-11609-1-git-send-email-hector.palacios@digi.com \
--to=hector.palacios@digi.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=maxime.ripard@free-electrons.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®