From: Chanho Min <chanho.min@lge.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Nadia Yvette Chambers <nyc@holomorphy.com>,
Jiri Kosina <jkosina@suse.cz>, Guennadi Liakhovetski <lg@denx.de>
Cc: linux-kernel@vger.kernel.org, Chanho Min <chanho.min@lge.com>
Subject: [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0
Date: Tue, 9 Apr 2013 11:44:46 +0900 [thread overview]
Message-ID: <1365475486-14371-1-git-send-email-chanho.min@lge.com> (raw)
If bitmap_find_free_region() is called with order=0, We can reduce
for-loops to find 1 free bit. First, It scans bitmap array by the
increment of long type, then find 1 free bit within 1 long type value.
In 32 bits system and 1024 bits size, in the worst case, We need 1024
for-loops to find 1 free bit. But, If This is applied, it takes
64 for-loops. Instead, if free bit is in the first index of the bitmaps,
It will be needed additional 1 for-loop. But from second index, It
will speed up significantly.
Changes compared to v1:
- Modified unnecessarily complicated code.
- Fixed the buggy code if `bits' is not an multiple of BITS_PER_LONG.
Signed-off-by: Chanho Min <chanho.min@lge.com>
---
lib/bitmap.c | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index 06f7e4f..663fc28 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1099,6 +1099,39 @@ done:
}
/**
+ * bitmap_find_free_one - find a mem region
+ * @bitmap: array of unsigned longs corresponding to the bitmap
+ * @bits: number of bits in the bitmap
+ *
+ * Find one of free (zero) bits in a @bitmap of @bits bits and
+ * allocate them (set them to one).
+ *
+ * Return the bit offset in bitmap of the allocated region,
+ * or -errno on failure.
+ */
+static int __bitmap_find_free_one(unsigned long *bitmap, int bits)
+{
+ int pos, end = BITS_PER_LONG, i;
+ int nlongs_reg = BITS_TO_LONGS(bits);
+ int last_bits = bits % BITS_PER_LONG;
+
+ for (i = 0 ; i < nlongs_reg ; i++) {
+ if (bitmap[i] != ~0UL) {
+ if (i == (nlongs_reg - 1) && last_bits)
+ end = last_bits;
+ for (pos = 0 ; pos < end ; pos++) {
+ if (!__reg_op(&bitmap[i], pos, 0,
+ REG_OP_ISFREE))
+ continue;
+ __reg_op(&bitmap[i], pos, 0, REG_OP_ALLOC);
+ return pos;
+ }
+ }
+ }
+ return -ENOMEM;
+}
+
+/**
* bitmap_find_free_region - find a contiguous aligned mem region
* @bitmap: array of unsigned longs corresponding to the bitmap
* @bits: number of bits in the bitmap
@@ -1116,6 +1149,9 @@ int bitmap_find_free_region(unsigned long *bitmap, int bits, int order)
{
int pos, end; /* scans bitmap by regions of size order */
+ if (order == 0)
+ return __bitmap_find_free_one(bitmap, bits);
+
for (pos = 0 ; (end = pos + (1 << order)) <= bits; pos = end) {
if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
continue;
--
1.7.9.5
next reply other threads:[~2013-04-09 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 2:44 Chanho Min [this message]
2013-04-09 3:10 ` Andrew Morton
2013-04-09 3:18 ` Joe Perches
2013-04-09 4:18 ` Andrew Morton
2013-04-09 4:27 ` checkpatch: Warn on space before semicolon Joe Perches
[not found] ` <5163b689.64d3440a.731b.ffff9984SMTPIN_ADDED_BROKEN@mx.google.com>
2013-04-09 20:22 ` [PATCH v2] bitmap: speedup in bitmap_find_free_region when order is 0 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365475486-14371-1-git-send-email-chanho.min@lge.com \
--to=chanho.min@lge.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=lg@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nyc@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®