From: Joe Perches <joe@perches.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
patches@linaro.org, chanho61.park@samsung.com,
kgene.kim@samsung.com
Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings
Date: Mon, 08 Apr 2013 20:09:05 -0700 [thread overview]
Message-ID: <1365476945.2012.2.camel@joe-AO722> (raw)
In-Reply-To: <CAK9yfHzvJ+5voHuJLCNb55yB0x5R8LS=FqoCu9tn5bSXZ_BNsQ@mail.gmail.com>
On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
> On 13 March 2013 14:42, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > Fixes the following warnings:
> > WARNING: line over 80 characters
> > WARNING: Prefer pr_warn(... to pr_warning(...
> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
[]
> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
[]
> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> > + pr_warn("%s: irq desc alloc failed. "
> > + "Continuing with %d as linux irq base\n",
> > + __func__, irq_base);
Please don't split formats.
See Documentation/CodingStyle Chapter 2
pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
__func__, irq_base);
next prev parent reply other threads:[~2013-04-09 3:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 9:12 Sachin Kamat
2013-04-09 3:03 ` Sachin Kamat
2013-04-09 3:09 ` Joe Perches [this message]
2013-04-09 3:36 ` Sachin Kamat
2013-04-09 3:45 ` Joe Perches
2013-04-09 3:50 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365476945.2012.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=chanho61.park@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®