From: Joe Perches <joe@perches.com>
To: Matthijs Kooijman <matthijs@stdin.nl>
Cc: Andy Whitcroft <apw@canonical.com>,
Paul Zimmerman <Paul.Zimmerman@synopsys.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Check block comments outside of net
Date: Tue, 09 Apr 2013 04:32:54 -0700 [thread overview]
Message-ID: <1365507174.6865.31.camel@joe-AO722> (raw)
In-Reply-To: <20130409111958.GG13691@login.drsnuggles.stderr.nl>
On Tue, 2013-04-09 at 13:19 +0200, Matthijs Kooijman wrote:
> There was some code checking block comments in net/ and drivers/net/,
> but nothing to check the regular block comment style.
[]
> Note that this patch rejects /** comments, since those are not mentioned
> in Codingstyle. They are used in practice though (around 1000 occurences
> in kernel/ alone), so perhaps they should be allowed and documented?
Those are kernel-doc comments and must be allowed.
see Documentation/kernel-doc-nano-HOWTO.txt
> Also, the new check only fires when the previous line is empty, just
> like the start of block comment check for net/. However, I couldn't find
> any documentation on why this restriction is needed?
I'm not that concerned about block comment style.
Maybe others are.
Please make it a --strict (CHK) only test for now.
next prev parent reply other threads:[~2013-04-09 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 11:19 Matthijs Kooijman
2013-04-09 11:26 ` [PATCH v2] " Matthijs Kooijman
2013-04-09 11:32 ` Joe Perches [this message]
2013-04-09 11:37 ` [PATCH] " Matthijs Kooijman
2013-04-10 8:59 ` [PATCH v3] checkpatch: check " Matthijs Kooijman
2013-04-10 9:05 ` [PATCH v4] " Matthijs Kooijman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365507174.6865.31.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Paul.Zimmerman@synopsys.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthijs@stdin.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®