From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935655Ab3DIMIG (ORCPT ); Tue, 9 Apr 2013 08:08:06 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:51665 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935437Ab3DIMIE (ORCPT ); Tue, 9 Apr 2013 08:08:04 -0400 X-AuditID: cbfee68d-b7f786d000005188-20-516404a2a539 Message-id: <1365509231.4353.100.camel@kjgkr> Subject: Re: [PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem From: Jaegeuk Kim Reply-to: jaegeuk.kim@samsung.com To: Namjae Jeon Cc: Steven Rostedt , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon Date: Tue, 09 Apr 2013 21:07:11 +0900 In-reply-to: References: <1365227126-15355-1-git-send-email-linkinjeon@gmail.com> <1365467115.25498.35.camel@gandalf.local.home> Organization: samsung Content-type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-nDFvOn7Q/BTEL1C1h0FG" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e+Zse4ilpRAgxPPrS2u373FbHFpkbvF nr0nWSwu75rDZvFjer3Fvo4HTA5sHjtn3WX3aNl3i91j94LPTB59W1YxenzeJBfAGsVlk5Ka k1mWWqRvl8CV8fr0Z9aCveoVj1/dZGxgXKTUxcjJISFgIrF+w2EWCFtM4sK99WxdjFwcQgLL GCU+tO0ESnCAFU1ZwggRX8Qo0bjuMVTRa0aJE7ubwLp5BXQlFt6ezQ5iCwv4SPTtmQ7WzCag LbF5vwFIWEhAUeLt/rusIGERATWJCc9SQcYwC+xglLj24AAbSA2LgKrE0tYbTCA1nALBEh/3 m0Os2sMosadhEth4fgFRiZOtnxhBbGaBKom2ppnsEA8oSexu72SHOEdQ4sfkeywgzRICczkk Gg4sZoJYICDxbfIhqMdkJTYdYIbolZQ4uOIGywRG8VlIxs5CMgoirinRuv03O4StLbFs4Wtm CNtWYt2691A1NhKbri5ghLDlJba/ncO8gJF9FaNoakFyQXFSepGhXnFibnFpXrpecn7uJkZI fPfuYLx9wPoQYxXQiROZpUST84HpIa8k3tDYzMjC1MTU2Mjc0owqwkrivGot1oFCAumJJanZ qakFqUXxRaU5qcWHGJk4OKUaGMstls9eybsnLu75z/l/JDRT2d/eM9/4/eyHZ7MKDbdsn2oy SZObcT8jd2nUkfd2tgtW23IES5vnOK04mPjuq+6vtWxbRLTWLqsPYtHr9HZ0s10y2SrlUXo8 P4Pjv0uPPwdNduqaF/2m5UX+s536r8yTWBud8+1Whp5VCs+VnbI94siS+ZGFZ5RYijMSDbWY i4oTAb7Ac4ccAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupik+LIzCtJLcpLzFFi42I5/e+xgO4ilpRAgwW7zCyu373FbHFpkbvF nr0nWSwu75rDZvFjer3Fvo4HTA5sHjtn3WX3aNl3i91j94LPTB59W1YxenzeJBfAGtXAaJOR mpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdICSQlliTilQ KCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMeP16c+sBXvVKx6/usnYwLhIqYuRg0NC wERiyhLGLkZOIFNM4sK99WxdjFwcQgKLGCUa1z2Gcl4zSpzY3cQCUsUroCux8PZsdhBbWMBH om/PdBaQQWwC2hKb9xuAhIUEFCXe7r/LChIWEVCTmPAsFWQMs8AORolrDw6wgdSwCKhKLG29 wQRSwykQLPFxvznEqj2MEnsaJoGN5xcQlTjZ+gnsOGaBKom2ppnsEIcqSexu72SHOEdQ4sfk eywTGAVnISmbhSQFEdeUaN3+mx3C1pZYtvA1M4RtK7Fu3XuoGhuJTVcXMELY8hLb385hXsDI vopRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjOHk8k97BuKrB4hCjAAejEg/vhSdJgUKsiWXF lbmHGFWA5jzasPoCoxRLXn5eqpIIb8ud5EAh3pTEyqrUovz4otKc1OJDjBMZgcExkVlKNDkf mPLySuINjU3MjCyNzCyMTMzNaSmsJM57sNU6UEggPbEkNTs1tSC1COYoJg5OqQbGplR1305r Ls0WH0bL7xcOhu99fOnebYE7aVryW4sV4ktvFWU9ET5TbLeg6Gne5ab8LYzVrI48+08a7576 sqO8wLQ+h3NCbfjXqWaCGT3l7yPDlf+/04w5cyIy6PYt8zbbn60Rb6zNLXa59evvSL4xJ1/x vqDijCkylttvrhd5pcNfvPRihJ0SS3FGoqEWc1FxIgA8zoLRnQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-nDFvOn7Q/BTEL1C1h0FG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2013-04-09 (=ED=99=94), 10:04 +0900, Namjae Jeon: > 2013/4/9, Steven Rostedt : > > On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote: > >> From: Namjae Jeon > >> > >> Add tracepoints in f2fs filesystem for tracing the filesystem > >> operations for information/debugging purpose if needed. All the > >> tracepoints are clubbed with respect to functionalities. > >> > >> Change Log: > >> v3: Introduced TRACE_EVENT_CONDITION() macro for checking the > >> condition page->mapping inside the trace point function call as > >> per Steve's review comment for the patch > >> > >> v2: Added DECLARE_EVENT_CLASS() macro for combining the similar > >> type of trace function calls which has same type of arguments. > >> > >> v1: Introduced the tracepoint functions in f2fs filesystem. > >> > >> Namjae Jeon (7): > >> f2fs: add tracepoints for sync & Inode operations > >> f2fs: add tracepoints for truncate operation > >> f2fs: add tracepoint for tracing the page i/o operations > >> f2fs: add tracepoints for GC threads > >> f2fs: add tracepoints to debug the block allocation & fallocate > >> f2fs: add tracepoints for write page operations > >> f2fs: add tracepoints to debug checkpoint request > >> > > > Hi. Steve. > > I have nothing more to add about the tracepoint processing. Looks good. > > Now if the tracepoints give you sufficient data? That's up to the > > maintainers to decide. > Until now, yes. but I will continously try to update trace point more > if finding additional needed points after. > Thanks for review and your ack. Thank you, Steve. :) To Namjae, I've reviewed the patch-set in terms of more informative tracepoints, and summarized what I'd like to suggest. Could you examine the following tracepoints? I really appreciate your job. Thanks, *format* tracepoint [its location] (information) 1. patch 1/7:=20 f2fs_sync_file_enter [enter] (dev,ino,parent,i_mode,i_nlink,i_blocks,fi->i_advise,fi->i_pino,datasync) f2fs_sync_file_exit [exit] (dev,ino,need_cp,ret) f2fs_sync_fs [enter] (dev,sbi->s_dirty,wait) f2fs_iget_enter [enter] (dev,ino) f2fs_iget_exit [exit] (dev,ino,ret) f2fs_evict_inode [enter] (dev,ino,i_nlink,i_blocks) f2fs_unlink_enter [enter] (dev,ino,i_blocks,dentry->d_name,parent->i_ino) f2fs_unlink_exit [exit] (dev,ino,ret) 2. patch 2/7: truncate_blocks_enter [enter] (dev,ino,from) truncate_blocks_exit [exit] (dev,ino, err) truncate_inode_blocks_enter [enter] (dev,ino,from) truncate_inode_blocks_exit [exit] (dev,ino,err) truncate_partial_nodes [exit] (dev,ino,nid[0],nid[1],nid[2],depth,err) truncate_data_blocks_range [exit] (dev,ino,dn->nid,dn->ofs_in_node,nr_free) truncate_node [exit] (dev,ino,dn->nid,ni.blk_addr) 3. patch 3/7: get_data_block_ro [all_exits] (dev,ino,iblock,bh_result->b_blocknr,bh_result->b_size,err) f2fs_readpage [enter] (dev,ino,index,blk_addr,type) 4. patch 4/7: get_victim_by_default [exit] (dev,gc_type,type,p.alloc_mode,p.gc_mode,p.ofs_unit,p.min_segno,sbi->cur_vi= ctim_sec) 5. patch 5/7: f2fs_fallocate [exit] (dev,ino,offset,len,mode,i_blocks,i_size,ret) f2fs_reserve_new_block [ext] (dev,ino,dn->nid,dn->ofs_in_node) 6. patch 6/7: submit_write_page [exit] (dev,ino,index,blk_addr,type) do_submit_bio [if(sbi->bio[btype]] (dev,btype,sync,bio->bi_sector,bio->bi_size) f2fs_write_begin [enter] (dev,ino,pos,len,flags) 7. patch 7/7: write_checkpoint_before_blockop [before block_operations()] (dev,is_mount,"try to block operations") write_checkpoint_after_blockop [after block_operations()] (dev,is_mount,"done block operations") write_checkpoint_exit [exit] (dev,is_mount,"done checkpoint") >=20 > > > > Acked-by: Steven Rostedt > > > > -- Steve > > > > > > --=20 Jaegeuk Kim Samsung --=-nDFvOn7Q/BTEL1C1h0FG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRZARvAAoJEEAUqH6CSFDSxKkP/3KULtDwPcK2ktw/PR8LB04v q6JyItNW+mKB8tJiXtmRRDB7EOMYGRW2iDrdW9IQrnvf0SxP1OfXKLf1r0I8YUxI /DF1PzhHK4hwiaoQjIfSvh31VpwlhXX9KTAfdb8lgafGbjlyyPWThCRx+yilcDmT Vjh67fenvr/Scb7f3aNZ0Cp32O9w7WkLr5qe4N4OzjO9U8P9lM9Kmo4rR+jdMnLo TDEKQX9MJNeJU0wGZky++svoYZ3BBCGH7Xi6NniAmSfRuhuk3+A+cNkIeRCrPSmQ irE14NVnDZOgTMALQ0cBAAFJU5N2IhIoKvuNXWC2JHTTSlHA/DVrOaAq9osdi1Gb nJiiQT7+/dFTowvgN4trDrTBN3z7pM2Zl5QFuoURfHZrtp+3yhCEzChxOogrhcIJ i/tG0qAXGcQeZUw2F5y2JgMsMR4hgIRjgNBaL7eJGiU4EIJUdrJu5r9LD9g4npeH EdzVqxLthB9pIan2qYyndjj+AehrTh445nfIr8lrYYgxnMsCYD/DtGtYOSXXFF9l i8jZ5GAHG6/q4JH6hife5FGd+q+p78ZeNu6AlxbuZcz/1S2q+5y2smMWlyWW3+Km ddLVVzKBD0dOXxKi4ZiKBIp1OFFp/k1mlHW4YbJHdQ9WjvmuN6AHc9ovlQdipJAv zLi3Qxc0uMCo2xHESGwR =dSHM -----END PGP SIGNATURE----- --=-nDFvOn7Q/BTEL1C1h0FG--