From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754582Ab3DKUYy (ORCPT ); Thu, 11 Apr 2013 16:24:54 -0400 Received: from mail-qc0-f201.google.com ([209.85.216.201]:52645 "EHLO mail-qc0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798Ab3DKUYx (ORCPT ); Thu, 11 Apr 2013 16:24:53 -0400 From: Andrew Bresticker To: linux-fbdev@vger.kernel.org Cc: Richard Purdie , Florian Tobias Schandinat , linux-kernel@vger.kernel.org, Doug Anderson , Andrew Bresticker Subject: [PATCH v2] backlight: platform_lcd: introduce probe callback Date: Thu, 11 Apr 2013 13:24:50 -0700 Message-Id: <1365711890-15168-1-git-send-email-abrestic@chromium.org> X-Mailer: git-send-email 1.8.1.3 In-Reply-To: <1365705391-23181-1-git-send-email-abrestic@chromium.org> References: <1365705391-23181-1-git-send-email-abrestic@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Platform LCD devices may need to do some device-specific initialization before they can be used (regulator or GPIO setup, for example), but currently the driver does not support any way of doing this. This patch adds a probe() callback to plat_lcd_data which platform LCD devices can set to indicate that device-specific initialization is needed. Signed-off-by: Andrew Bresticker --- drivers/video/backlight/platform_lcd.c | 6 ++++++ include/video/platform_lcd.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c index 17a6b83..f46180e 100644 --- a/drivers/video/backlight/platform_lcd.c +++ b/drivers/video/backlight/platform_lcd.c @@ -86,6 +86,12 @@ static int platform_lcd_probe(struct platform_device *pdev) return -EINVAL; } + if (pdata->probe) { + err = pdata->probe(pdata); + if (err) + return err; + } + plcd = devm_kzalloc(&pdev->dev, sizeof(struct platform_lcd), GFP_KERNEL); if (!plcd) { diff --git a/include/video/platform_lcd.h b/include/video/platform_lcd.h index ad3bdfe..23864b2 100644 --- a/include/video/platform_lcd.h +++ b/include/video/platform_lcd.h @@ -15,6 +15,7 @@ struct plat_lcd_data; struct fb_info; struct plat_lcd_data { + int (*probe)(struct plat_lcd_data *); void (*set_power)(struct plat_lcd_data *, unsigned int power); int (*match_fb)(struct plat_lcd_data *, struct fb_info *); }; -- 1.8.1.3