mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiang Liu <liuj97@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>, "Rafael J . Wysocki" <rjw@sisk.pl>
Cc: Jiang Liu <jiang.liu@huawei.com>, Yinghai Lu <yinghai@kernel.org>,
	Yijing Wang <wangyijing@huawei.com>, Jiang Liu <liuj97@gmail.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Toshi Kani <toshi.kani@hp.com>,
	Myron Stowe <myron.stowe@redhat.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH v9 01/16] PCI: do not check is_added flag in pci_remove_bus()
Date: Fri, 12 Apr 2013 23:44:15 +0800	[thread overview]
Message-ID: <1365781470-32379-2-git-send-email-jiang.liu@huawei.com> (raw)
In-Reply-To: <1365781470-32379-1-git-send-email-jiang.liu@huawei.com>

The is_added flag in struct pci_bus is always set after invoking
device_register() and pci_create_legacy_files(). The related code
paths are:
1) pci_create_root_bus() and pci_add_new_bus()
	bus = pci_alloc_bus()
	device_register(&bus->dev)
	pci_create_legacy_file(bus)
2.a) pci_scan_child_bus(bus)
	set is_added flag for PCI root buses
2.b) pci_bus_add_devices(bus)
	set is_added flag for normal PCI buses

So pci_remove_bus() shouldn't use is_added flag to guard invoking of
pci_remove_lagecy_files() and device_unregister().

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/pci/remove.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index cc875e6..a831880 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -50,9 +50,6 @@ void pci_remove_bus(struct pci_bus *bus)
 	list_del(&bus->node);
 	pci_bus_release_busn_res(bus);
 	up_write(&pci_bus_sem);
-	if (!bus->is_added)
-		return;
-
 	pci_remove_legacy_files(bus);
 	device_unregister(&bus->dev);
 }
-- 
1.7.9.5


  reply	other threads:[~2013-04-12 15:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 15:44 [PATCH v9 00/16] Get rid of the ACPI PCI subdriver mechanism Jiang Liu
2013-04-12 15:44 ` Jiang Liu [this message]
2013-04-12 15:44 ` [PATCH v9 02/16] pci: clean up usages of pci_bus->is_added Jiang Liu
2013-04-12 15:44 ` [PATCH v9 03/16] PCI/acpiphp: use list_for_each_entry_safe() in acpiphp_sanitize_bus() Jiang Liu
2013-04-12 15:44 ` [PATCH v9 04/16] PCI/acpiphp: don't rely on function 0 in disable_device() Jiang Liu
2013-04-12 15:44 ` [PATCH v9 05/16] ACPI/acpiphp: replace local macros with standard ACPI macros Jiang Liu
2013-04-12 15:44 ` [PATCH v9 06/16] PCI: introduce platform dependent hooks for creating/destroying PCI busses Jiang Liu
2013-04-12 15:44 ` [PATCH v9 07/16] PCI, ACPI: prepare stub functions to handle ACPI PCI (hotplug) slots Jiang Liu
2013-04-12 15:44 ` [PATCH v9 08/16] PCI, IA64: implement pcibios_{add|remove}_bus() hooks Jiang Liu
2013-04-12 15:44 ` [PATCH v9 09/16] PCI, x86: " Jiang Liu
2013-04-16 20:27   ` David Rientjes
2013-04-16 22:35     ` Bjorn Helgaas
2013-04-17 20:49       ` David Rientjes
2013-04-17  0:00     ` Jiang Liu
2013-04-12 15:44 ` [PATCH v9 10/16] PCI, ACPI: handle PCI slot devices when creating/destroying PCI busses Jiang Liu
2013-04-12 15:44 ` [PATCH v9 11/16] PCI/acpiphp: convert acpiphp as a builtin driver Jiang Liu
2013-04-12 15:44 ` [PATCH v9 12/16] PCI/acpiphp: do not use ACPI PCI subdriver mechanism Jiang Liu
2013-04-12 15:44 ` [PATCH v9 13/16] PCI/acpiphp: use normal list to simplify implementation Jiang Liu
2013-04-12 15:44 ` [PATCH v9 14/16] PCI/acpiphp: protect acpiphp data structures from concurrent updating Jiang Liu
2013-04-12 15:44 ` [PATCH v9 15/16] PCI/acpiphp: introduce a kernel option to disable the acpiphp driver Jiang Liu
2013-04-12 15:44 ` [PATCH v9 16/16] PCI, ACPI: remove support of ACPI PCI subdrivers Jiang Liu
2013-04-12 22:17 ` [PATCH v9 00/16] Get rid of the ACPI PCI subdriver mechanism Bjorn Helgaas
2013-04-13  4:03   ` Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365781470-32379-2-git-send-email-jiang.liu@huawei.com \
    --to=liuj97@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiang.liu@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=myron.stowe@redhat.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rjw@sisk.pl \
    --cc=toshi.kani@hp.com \
    --cc=wangyijing@huawei.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®