From: Andrey Vagin <avagin@openvz.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-kernel@vger.kernel.org, Andrey Vagin <avagin@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Oleg Nesterov <oleg@redhat.com>,
David Howells <dhowells@redhat.com>
Subject: [PATCH] kernel: move exit_task_work() past exit_notify()
Date: Fri, 12 Apr 2013 23:27:33 +0400 [thread overview]
Message-ID: <1365794853-23912-1-git-send-email-avagin@openvz.org> (raw)
exit_task_work() must be called after exit_notify, because
exit_task_namespaces() may release a file and fput() enqueues a work.
exit_notify
exit_task_namespaces
free_ipc_ns
shm_destroy
fput
task_work_add
so if task works don't run after exit_notify(), a few files may leak.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
kernel/exit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index 60bc027..1d1129b 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -795,7 +795,6 @@ void do_exit(long code)
exit_shm(tsk);
exit_files(tsk);
exit_fs(tsk);
- exit_task_work(tsk);
check_stack_usage();
exit_thread();
@@ -822,6 +821,7 @@ void do_exit(long code)
ptrace_put_breakpoints(tsk);
exit_notify(tsk, group_dead);
+ exit_task_work(tsk);
#ifdef CONFIG_NUMA
task_lock(tsk);
mpol_put(tsk->mempolicy);
--
1.8.1.4
next reply other threads:[~2013-04-12 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 19:27 Andrey Vagin [this message]
2013-04-13 14:22 ` Oleg Nesterov
2013-04-13 15:54 ` [PATCH 0/1] (Was: kernel: move exit_task_work() past exit_notify()) Oleg Nesterov
2013-04-13 15:55 ` [PATCH 1/1] move exit_task_namespaces() outside of exit_notify() Oleg Nesterov
2013-04-14 1:52 ` Eric W. Biederman
2013-04-15 9:57 ` Andrey Wagin
2013-04-15 15:33 ` Oleg Nesterov
2013-06-13 9:24 ` Andrew Vagin
2013-06-14 13:19 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365794853-23912-1-git-send-email-avagin@openvz.org \
--to=avagin@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®