From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Joe Perches <joe@perches.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg
Date: Mon, 15 Apr 2013 02:56:13 +0100 (BST) [thread overview]
Message-ID: <1365990973.28177.YahooMailClassic@web172303.mail.ir2.yahoo.com> (raw)
In-Reply-To: <1365990674.1878.21.camel@joe-AO722>
--- On Mon, 15/4/13, Joe Perches <joe@perches.com> wrote:
> On Mon, 2013-04-15 at 01:53 +0100,
> Hin-Tak Leung wrote:
> > --- On Mon, 8/4/13, Joe Perches <joe@perches.com>
> wrote:
> > > Use a more current logging style.
> []
> > I have been sitting on a patch which changes this part
> of the code to dynamic debugging, and it is much simplier.
> Just:
> > #define dprint(flg, fmt, args...) \
> > - if (flg &
> DBG_MASK) \
> > -
> printk(fmt , ## args)
> > +
> pr_debug(fmt , ## args)
>
> This change wouldn't work well as it would make a mess
> of output that uses no prefix (ie: emits at KERN_DEFAULT)
> with output that uses KERN_DEBUG
>
> That's the reason for _dbg and _dbg_cont.
Hmm, I don't get it. Is there any *existing* use of dprint in the hfplus code which is affected by your comment? Or is this another general stylistic comment? i.e. "this does not work in general"?
next prev parent reply other threads:[~2013-04-15 1:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 21:44 [PATCH] hfs: add error checking for hfs_find_init() Alexey Khoroshilov
2013-03-30 11:35 ` Vyacheslav Dubeyko
2013-03-30 14:01 ` Hin-Tak Leung
2013-04-06 21:13 ` Alexey Khoroshilov
2013-04-07 9:31 ` Vyacheslav Dubeyko
2013-04-07 21:21 ` [PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Alexey Khoroshilov
2013-04-07 21:21 ` [PATCH 2/2] hfsplus: add printk to log allocation failure in hfs_find_init() Alexey Khoroshilov
2013-04-07 22:00 ` Joe Perches
2013-04-08 6:08 ` Vyacheslav Dubeyko
2013-04-08 16:37 ` [PATCH 0/2] hfs/hfsplus: Modernize logging styles Joe Perches
2013-04-08 16:37 ` [PATCH 1/2] hfs/hfsplus: Convert dprint to hfs_dbg Joe Perches
2013-04-09 7:08 ` Vyacheslav Dubeyko
2013-04-15 0:53 ` Hin-Tak Leung
2013-04-15 1:51 ` Joe Perches
2013-04-15 1:56 ` Hin-Tak Leung [this message]
2013-04-15 2:06 ` Joe Perches
2013-04-15 3:46 ` Hin-Tak Leung
2013-04-15 4:00 ` Joe Perches
2013-04-15 4:22 ` Hin-Tak Leung
2013-04-15 4:38 ` Joe Perches
2013-04-08 16:37 ` [PATCH 2/2] hfs/hfsplus: Convert printks to pr_<level> Joe Perches
2013-04-09 7:08 ` Vyacheslav Dubeyko
2013-04-09 7:08 ` [PATCH 0/2] hfs/hfsplus: Modernize logging styles Vyacheslav Dubeyko
2013-04-09 10:39 ` Joe Perches
2013-04-09 11:06 ` Vyacheslav Dubeyko
2013-04-08 5:55 ` [PATCH 1/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Vyacheslav Dubeyko
2013-04-09 18:14 ` [PATCH 1/2] hfs: add error checking for hfs_find_init() Alexey Khoroshilov
2013-04-09 18:14 ` [PATCH 2/2] hfsplus: add error propagation to __hfsplus_ext_write_extent() Alexey Khoroshilov
2013-04-10 6:40 ` Vyacheslav Dubeyko
2013-04-10 6:40 ` [PATCH 1/2] hfs: add error checking for hfs_find_init() Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365990973.28177.YahooMailClassic@web172303.mail.ir2.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®