From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Tony Lindgren <tony@atomide.com>
Cc: <rtc-linux@googlegroups.com>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
Christoph Fritz <chf.fritz@googlemail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Tomi Valkeinen <tomi.valkeinen@iki.fi>
Subject: [PATCH v2 1/2] RTC: rtc-twl: Fix rtc_reg_map initialization
Date: Tue, 16 Apr 2013 10:30:12 +0200 [thread overview]
Message-ID: <1366101013-21183-1-git-send-email-peter.ujfalusi@ti.com> (raw)
Initialize the rtc_reg_map in platform_driver's probe function instead at
module_init time. This way we can make sure that the twl-core has been already
probed and initialized (twl_priv->twl_id is valid) since the platform device
for the RTC driver will be created by the twl-core after it finished it's
init.
Reported-by: Christoph Fritz <chf.fritz@googlemail.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi,
As Tomi commented on the first version:
www.spinics.net/lists/linux-omap/msg90064.html
www.spinics.net/lists/linux-omap/msg90066.html
I have separated the actual fix from the module_platform_driver() conversion.
Regards,
Peter
drivers/rtc/rtc-twl.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index 8bc6c80..c385e9b 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -469,6 +469,12 @@ static int twl_rtc_probe(struct platform_device *pdev)
if (irq <= 0)
goto out1;
+ /* Initialize the register map */
+ if (twl_class_is_4030())
+ rtc_reg_map = (u8 *)twl4030_rtc_reg_map;
+ else
+ rtc_reg_map = (u8 *)twl6030_rtc_reg_map;
+
ret = twl_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG);
if (ret < 0)
goto out1;
@@ -614,11 +620,6 @@ static struct platform_driver twl4030rtc_driver = {
static int __init twl_rtc_init(void)
{
- if (twl_class_is_4030())
- rtc_reg_map = (u8 *) twl4030_rtc_reg_map;
- else
- rtc_reg_map = (u8 *) twl6030_rtc_reg_map;
-
return platform_driver_register(&twl4030rtc_driver);
}
module_init(twl_rtc_init);
--
1.8.1.5
next reply other threads:[~2013-04-16 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 8:30 Peter Ujfalusi [this message]
2013-04-16 8:30 ` [PATCH v2 2/2] RTC: rtc-twl: Cleanup with module_platform_driver() conversion Peter Ujfalusi
2013-06-05 18:05 ` Kevin Hilman
2013-06-05 11:49 ` [PATCH v2 1/2] RTC: rtc-twl: Fix rtc_reg_map initialization Grygorii Strashko
2013-06-05 18:03 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366101013-21183-1-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=a.zummo@towertech.it \
--cc=chf.fritz@googlemail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tomi.valkeinen@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®