From: Joe Perches <joe@perches.com>
To: Robin Holt <holt@sgi.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file.
Date: Tue, 16 Apr 2013 08:10:29 -0700 [thread overview]
Message-ID: <1366125029.18313.5.camel@joe-AO722> (raw)
In-Reply-To: <20130416094100.GK3658@sgi.com>
(trimmed cc's)
On Tue, 2013-04-16 at 04:41 -0500, Robin Holt wrote:
> On Mon, Apr 15, 2013 at 10:45:38AM -0700, Joe Perches wrote:
> > trivia:
> > I'd make these changes on top of your patch:
> > o Additional OOM messages aren't necessary as a dump_stack is done
> I am not sure what I should be doing with this one.
It could be removed eventually.
> The only message
> that seems close is the pr_warn("%s failed to allocate memory for...
> but I don't see how dump_stack is getting invoked so I think either
> you did not mean this message or you intended me to replace that with a
> dump_stack, in which case, the error message would still be informative
> and the dump_stack would be relatively useless.
All failed mallocs without __GFP_NOWARN get a dump_stack via
mm/page_alloc:warn_alloc_failed() so that pr_warn isn't really
required.
next prev parent reply other threads:[~2013-04-16 15:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 17:12 [Patch -v3 0/4] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-04-15 17:14 ` [Patch -v3 1/4] Migrate shutdown/reboot to boot cpu Robin Holt
2013-04-16 3:02 ` Shawn Guo
2013-04-15 17:15 ` [Patch -v3 2/4] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-04-15 17:38 ` Joe Perches
2013-04-15 17:16 ` [Patch -v3 3/4] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-04-15 17:45 ` Joe Perches
2013-04-15 18:39 ` Robin Holt
2013-04-16 9:41 ` Robin Holt
2013-04-16 15:10 ` Joe Perches [this message]
2013-04-15 17:16 ` [Patch -v3 4/4] Make reboot_cpuid a kernel parameter Robin Holt
2013-04-15 17:18 ` H. Peter Anvin
2013-04-15 17:33 ` Robin Holt
2013-04-15 17:47 ` H. Peter Anvin
2013-04-15 18:22 ` Robin Holt
2013-04-16 9:01 ` Ingo Molnar
2013-04-16 9:24 ` Robin Holt
2013-04-16 9:29 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366125029.18313.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®